diff options
| author |   Jordan Crouse <jcrouse@codeaurora.org> | 2018-12-11 13:07:45 -0700 |
|---|---|---|
| committer |   Andy Gross <andy.gross@linaro.org> | 2019-02-12 15:27:14 -0600 |
| commit | 72d1cd033154f50e77cd4feb4e16c227b598632e (patch) | |
| tree | 06fbf3e0029aa0de953db993e49ae8cef4fb1423 /include/linux/soc | |
| parent | soc: qcom: smd-rpm: Add sdm660 compatible (diff) | |
| download | wireguard-linux-72d1cd033154f50e77cd4feb4e16c227b598632e.tar.xz wireguard-linux-72d1cd033154f50e77cd4feb4e16c227b598632e.zip | |
qcom: soc: llcc-slice: Clear the global drv_data pointer on error
Currently the data structure for llc-slice is devm allocated and
stored as a global but never cleared if the probe function fails.
This is a problem because devm managed memory gets freed on probe
failure the API functions could access the pointer after it has been
freed.
Initialize the drv_data pointer to an error and reset it to an error
on probe failure or device destroy and add protection to the API
functions to make sure the memory doesn't get accessed.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
Diffstat (limited to 'include/linux/soc')
| -rw-r--r-- | include/linux/soc/qcom/llcc-qcom.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h index 69c285b1c990..eb71a50b8afc 100644 --- a/include/linux/soc/qcom/llcc-qcom.h +++ b/include/linux/soc/qcom/llcc-qcom.h @@ -162,6 +162,12 @@ int llcc_slice_deactivate(struct llcc_slice_desc *desc); */ int qcom_llcc_probe(struct platform_device *pdev, const struct llcc_slice_config *table, u32 sz); + +/** + * qcom_llcc_remove - remove the sct table + * @pdev: Platform device pointer + */ +int qcom_llcc_remove(struct platform_device *pdev); #else static inline struct llcc_slice_desc *llcc_slice_getd(u32 uid) { |