diff options
| author |   Yosry Ahmed <yosry.ahmed@linux.dev> | 2025-03-19 21:00:13 +0000 |
|---|---|---|
| committer |   Tejun Heo <tj@kernel.org> | 2025-03-20 06:53:02 -1000 |
| commit | 093c8812de2d3436744fd10edab9bf816b94f833 (patch) | |
| tree | 9351971f502110e76032a7ee0693ef0bc95b5d41 /include/linux | |
| parent | cgroup/rstat: avoid disabling irqs for O(num_cpu) (diff) | |
| download | wireguard-linux-093c8812de2d3436744fd10edab9bf816b94f833.tar.xz wireguard-linux-093c8812de2d3436744fd10edab9bf816b94f833.zip | |
cgroup: rstat: Cleanup flushing functions and locking
Now that the rstat lock is being re-acquired on every CPU iteration in
cgroup_rstat_flush_locked(), having the initially acquire the lock is
unnecessary and unclear.
Inline cgroup_rstat_flush_locked() into cgroup_rstat_flush() and move
the lock/unlock calls to the beginning and ending of the loop body to
make the critical section obvious.
cgroup_rstat_flush_hold/release() do not make much sense with the lock
being dropped and reacquired internally. Since it has no external
callers, remove it and explicitly acquire the lock in
cgroup_base_stat_cputime_show() instead.
This leaves the code with a single flushing function,
cgroup_rstat_flush().
Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/cgroup.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 8e7415c64ed1..28e999f2c642 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -690,8 +690,6 @@ static inline void cgroup_path_from_kernfs_id(u64 id, char *buf, size_t buflen) */ void cgroup_rstat_updated(struct cgroup *cgrp, int cpu); void cgroup_rstat_flush(struct cgroup *cgrp); -void cgroup_rstat_flush_hold(struct cgroup *cgrp); -void cgroup_rstat_flush_release(struct cgroup *cgrp); /* * Basic resource stats. |