diff options
| author |   Baptiste Lepers <baptiste.lepers@gmail.com> | 2021-01-12 15:59:15 +0000 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2021-01-13 10:38:20 -0800 |
| commit | a95d25dd7b94a5ba18246da09b4218f132fed60e (patch) | |
| tree | 9e862148394de9b2ada9c57ca025b93160dd3a89 /net/can/isotp.c | |
| parent | rxrpc: Fix handling of an unsupported token type in rxrpc_read() (diff) | |
| download | wireguard-linux-a95d25dd7b94a5ba18246da09b4218f132fed60e.tar.xz wireguard-linux-a95d25dd7b94a5ba18246da09b4218f132fed60e.zip | |
rxrpc: Call state should be read with READ_ONCE() under some circumstances
The call state may be changed at any time by the data-ready routine in
response to received packets, so if the call state is to be read and acted
upon several times in a function, READ_ONCE() must be used unless the call
state lock is held.
As it happens, we used READ_ONCE() to read the state a few lines above the
unmarked read in rxrpc_input_data(), so use that value rather than
re-reading it.
Fixes: a158bdd3247b ("rxrpc: Fix call timeouts")
Signed-off-by: Baptiste Lepers <baptiste.lepers@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/161046715522.2450566.488819910256264150.stgit@warthog.procyon.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/can/isotp.c')
0 files changed, 0 insertions, 0 deletions