diff options
| author |   Jakub Kicinski <kuba@kernel.org> | 2021-10-30 10:18:50 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-11-01 13:26:07 +0000 |
| commit | 46db1b77cd4f082c4e908c8f8086a2f7aae28b62 (patch) | |
| tree | 7d43077c2639337ffdd30b8430dcdc13e51ac3b2 /net/core | |
| parent | ethtool: handle info/flash data copying outside rtnl_lock (diff) | |
| download | wireguard-linux-46db1b77cd4f082c4e908c8f8086a2f7aae28b62.tar.xz wireguard-linux-46db1b77cd4f082c4e908c8f8086a2f7aae28b62.zip | |
devlink: expose get/put functions
Allow those who hold implicit reference on a devlink instance
to try to take a full ref on it. This will be used from netdev
code which has an implicit ref because of driver call ordering.
Note that after recent changes devlink_unregister() may happen
before netdev unregister, but devlink_free() should still happen
after, so we are safe to try, but we can't just refcount_inc()
and assume it's not zero.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/devlink.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/net/core/devlink.c b/net/core/devlink.c index 2d8abe88c673..100d87fd3f65 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -182,15 +182,17 @@ struct net *devlink_net(const struct devlink *devlink) } EXPORT_SYMBOL_GPL(devlink_net); -static void devlink_put(struct devlink *devlink) +void devlink_put(struct devlink *devlink) { if (refcount_dec_and_test(&devlink->refcount)) complete(&devlink->comp); } -static bool __must_check devlink_try_get(struct devlink *devlink) +struct devlink *__must_check devlink_try_get(struct devlink *devlink) { - return refcount_inc_not_zero(&devlink->refcount); + if (refcount_inc_not_zero(&devlink->refcount)) + return devlink; + return NULL; } static struct devlink *devlink_get_from_attrs(struct net *net, |