diff options
| author |   Jerome Brunet <jbrunet@baylibre.com> | 2020-04-20 13:45:10 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2020-04-20 13:58:21 +0100 |
| commit | 1164284270779e1865cc2046a2a01b58a1e858a9 (patch) | |
| tree | 9b84da72ed8dc3f3b09e6966f0db69a36e0a8288 /sound/soc/meson/gx-card.c | |
| parent | ASoC: SOF: Intel: add min/max channels for SSP on Baytrail/Broadwell (diff) | |
| download | wireguard-linux-1164284270779e1865cc2046a2a01b58a1e858a9.tar.xz wireguard-linux-1164284270779e1865cc2046a2a01b58a1e858a9.zip | |
ASoC: meson: axg-card: fix codec-to-codec link setup
Since the addition of commit 9b5db059366a ("ASoC: soc-pcm: dpcm: Only allow
playback/capture if supported"), meson-axg cards which have codec-to-codec
links fail to init and Oops:
Unable to handle kernel NULL pointer dereference at virtual address 0000000000000128
Internal error: Oops: 96000044 [#1] PREEMPT SMP
CPU: 3 PID: 1582 Comm: arecord Not tainted 5.7.0-rc1
pc : invalidate_paths_ep+0x30/0xe0
lr : snd_soc_dapm_dai_get_connected_widgets+0x170/0x1a8
Call trace:
invalidate_paths_ep+0x30/0xe0
snd_soc_dapm_dai_get_connected_widgets+0x170/0x1a8
dpcm_path_get+0x38/0xd0
dpcm_fe_dai_open+0x70/0x920
snd_pcm_open_substream+0x564/0x840
snd_pcm_open+0xfc/0x228
snd_pcm_capture_open+0x4c/0x78
snd_open+0xac/0x1a8
...
While initiliazing the links, ASoC treats the codec-to-codec links of this
card type as a DPCM backend. This error eventually leads to the Oops.
Most of the card driver code is shared between DPCM backends and
codec-to-codec links. The property "no_pcm" marking DCPM BE was left set on
codec-to-codec links, leading to this problem. This commit fixes that.
Fixes: 0a8f1117a680 ("ASoC: meson: axg-card: add basic codec-to-codec link support")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20200420114511.450560-2-jbrunet@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions