diff options
| author |   Ian Rogers <irogers@google.com> | 2021-11-07 01:00:01 -0800 |
|---|---|---|
| committer |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2021-11-07 15:39:25 -0300 |
| commit | 07eafd4e053a41d72611848b8758df0752b53ee4 (patch) | |
| tree | 49140217f326f358935eaa4bcc6b15cd108139c3 /tools/perf/arch | |
| parent | perf parse-events: Rename parse_events_error functions (diff) | |
| download | wireguard-linux-07eafd4e053a41d72611848b8758df0752b53ee4.tar.xz wireguard-linux-07eafd4e053a41d72611848b8758df0752b53ee4.zip | |
perf parse-event: Add init and exit to parse_event_error
parse_events() may succeed but leave string memory allocations reachable
in the error.
Add an init/exit that must be called to initialize and clean up the
error. This fixes a leak in metricgroup parse_ids.
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: John Garry <john.garry@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20211107090002.3784612-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/arch')
| -rw-r--r-- | tools/perf/arch/powerpc/util/kvm-stat.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/arch/powerpc/util/kvm-stat.c b/tools/perf/arch/powerpc/util/kvm-stat.c index dc644ca01dc6..1a9b40ea92a5 100644 --- a/tools/perf/arch/powerpc/util/kvm-stat.c +++ b/tools/perf/arch/powerpc/util/kvm-stat.c @@ -113,10 +113,11 @@ static int is_tracepoint_available(const char *str, struct evlist *evlist) struct parse_events_error err; int ret; - bzero(&err, sizeof(err)); + parse_events_error__init(&err); ret = parse_events(evlist, str, &err); if (err.str) parse_events_error__print(&err, "tracepoint"); + parse_events_error__exit(&err); return ret; } |