diff options
| author |   Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-06-20 11:54:53 +0800 |
|---|---|---|
| committer |   Felipe Balbi <felipe.balbi@linux.intel.com> | 2018-07-17 10:12:51 +0300 |
| commit | 0602088b10a7c0b4e044a810678ef93d7cc5bf48 (patch) | |
| tree | 1589cd73d2b582c85561bd64d1106ae036614a5b /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | usb: gadget: Fix OS descriptors support (diff) | |
| download | wireguard-linux-0602088b10a7c0b4e044a810678ef93d7cc5bf48.tar.xz wireguard-linux-0602088b10a7c0b4e044a810678ef93d7cc5bf48.zip | |
usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller()
The driver may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.16.7 are:
[FUNC] msleep
drivers/usb/gadget/udc/r8a66597-udc.c, 839:
msleep in init_controller
drivers/usb/gadget/udc/r8a66597-udc.c, 96:
init_controller in r8a66597_usb_disconnect
drivers/usb/gadget/udc/r8a66597-udc.c, 93:
spin_lock in r8a66597_usb_disconnect
[FUNC] msleep
drivers/usb/gadget/udc/r8a66597-udc.c, 835:
msleep in init_controller
drivers/usb/gadget/udc/r8a66597-udc.c, 96:
init_controller in r8a66597_usb_disconnect
drivers/usb/gadget/udc/r8a66597-udc.c, 93:
spin_lock in r8a66597_usb_disconnect
To fix these bugs, msleep() is replaced with mdelay().
This bug is found by my static analysis tool (DSAC-2) and checked by
my code review.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions