diff options
| author |   Masahiro Yamada <masahiroy@kernel.org> | 2020-06-01 14:57:19 +0900 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-06 23:38:13 +0900 |
| commit | 7c8f5662c502b7b967399fef8a64532ec43b063d (patch) | |
| tree | e43532144df75586abca8681546cc43d6f09ffe8 /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | modpost: fix potential mmap'ed file overrun in get_src_version() (diff) | |
| download | wireguard-linux-7c8f5662c502b7b967399fef8a64532ec43b063d.tar.xz wireguard-linux-7c8f5662c502b7b967399fef8a64532ec43b063d.zip | |
modpost: avoid false-positive file open error
One problem of grab_file() is that it cannot distinguish the following
two cases:
- It cannot read the file (the file does not exist, or read permission
is not set)
- It can read the file, but the file size is zero
This is because grab_file() calls mmap(), which requires the mapped
length is greater than 0. Hence, grab_file() fails for both cases.
If an empty header file were included for checksum calculation, the
following warning would be printed:
WARNING: modpost: could not open ...: Invalid argument
An empty file is a valid source file, so it should not fail.
Use read_text_file() instead. It can read a zero-length file.
Then, parse_file() will succeed with doing nothing.
Going forward, the first case (it cannot read the file) is a fatal
error. If the source file from which an object was compiled is missing,
something went wrong.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions