diff options
| author |   Jason Wang <jasowang@redhat.com> | 2016-05-19 13:36:51 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-05-20 19:28:37 -0400 |
| commit | addf8fc4acb1cf79492ac64966f07178793cb3d7 (patch) | |
| tree | c0e712a1e95d2413004aeffd14ac45627b287c92 /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | Merge branch 'GREoIPV6-followups' (diff) | |
| download | wireguard-linux-addf8fc4acb1cf79492ac64966f07178793cb3d7.tar.xz wireguard-linux-addf8fc4acb1cf79492ac64966f07178793cb3d7.zip | |
tuntap: correctly wake up process during uninit
We used to check dev->reg_state against NETREG_REGISTERED after each
time we are woke up. But after commit 9e641bdcfa4e ("net-tun:
restructure tun_do_read for better sleep/wakeup efficiency"), it uses
skb_recv_datagram() which does not check dev->reg_state. This will
result if we delete a tun/tap device after a process is blocked in the
reading. The device will wait for the reference count which was held
by that process for ever.
Fixes this by using RCV_SHUTDOWN which will be checked during
sk_recv_datagram() before trying to wake up the process during uninit.
Fixes: 9e641bdcfa4e ("net-tun: restructure tun_do_read for better
sleep/wakeup efficiency")
Cc: Eric Dumazet <edumazet@google.com>
Cc: Xi Wang <xii@google.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions