diff options
author | 2021-01-11 14:09:04 -0800 | |
---|---|---|
committer | 2021-01-12 09:59:17 +0100 | |
commit | 161a582bd1d8681095f158d11bc679a58f1d026b (patch) | |
tree | 49f9a7cfa941258da3a8c80455c6b157ea10792d /tools/perf/scripts/python/export-to-postgresql.py | |
parent | Linux 5.11-rc3 (diff) | |
download | wireguard-linux-161a582bd1d8681095f158d11bc679a58f1d026b.tar.xz wireguard-linux-161a582bd1d8681095f158d11bc679a58f1d026b.zip |
USB: serial: mos7720: improve OOM-handling in read_mos_reg()
clang static analysis reports this problem
mos7720.c:352:2: warning: Undefined or garbage value returned to caller
return d;
^~~~~~~~
In the parport_mos7715_read_data()'s call to read_mos_reg(), 'd' is
only set after the alloc block.
buf = kmalloc(1, GFP_KERNEL);
if (!buf)
return -ENOMEM;
Although the problem is reported in parport_most7715_read_data(),
none of the callee's of read_mos_reg() check the return status.
Make sure to clear the return-value buffer also on allocation failures.
Fixes: 0d130367abf5 ("USB: serial: mos7720: fix control-message error handling")
Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20210111220904.1035957-1-trix@redhat.com
[ johan: only clear the buffer on errors, amend commit message ]
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions