diff options
author | 2014-10-02 09:04:31 +1000 | |
---|---|---|
committer | 2014-10-02 09:04:31 +1000 | |
commit | 61be9c529a4a715ab8679e9ca82bc3790c7ab66c (patch) | |
tree | 3e8d1c757133eb7c844cd4ba8815f4a6bc0218cb /tools/perf/scripts/python/export-to-postgresql.py | |
parent | xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality (diff) | |
download | wireguard-linux-61be9c529a4a715ab8679e9ca82bc3790c7ab66c.tar.xz wireguard-linux-61be9c529a4a715ab8679e9ca82bc3790c7ab66c.zip |
xfs: rework xfs_buf_bio_endio error handling
Currently the report of a bio error from completion
immediately marks the buffer with an error. The issue is that this
is racy w.r.t. synchronous IO - the submitter can see b_error being
set before the IO is complete, and hence we cannot differentiate
between submission failures and completion failures.
Add an internal b_io_error field protected by the b_lock to catch IO
completion errors, and only propagate that to the buffer during
final IO completion handling. Hence we can tell in xfs_buf_iorequest
if we've had a submission failure bey checking bp->b_error before
dropping our b_io_remaining reference - that reference will prevent
b_io_error values from being propagated to b_error in the event that
completion races with submission.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions