diff options
author | 2021-11-15 11:55:57 -0600 | |
---|---|---|
committer | 2021-11-17 10:30:28 -0600 | |
commit | e7f7c99ba911f56bc338845c1cd72954ba591707 (patch) | |
tree | 47003d63b966b2d66a7a13b16651ac74be80e7c2 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | Linux 5.16-rc1 (diff) | |
download | wireguard-linux-e7f7c99ba911f56bc338845c1cd72954ba591707.tar.xz wireguard-linux-e7f7c99ba911f56bc338845c1cd72954ba591707.zip |
signal: In get_signal test for signal_group_exit every time through the loop
Recently while investigating a problem with rr and signals I noticed
that siglock is dropped in ptrace_signal and get_signal does not jump
to relock.
Looking farther to see if the problem is anywhere else I see that
do_signal_stop also returns if signal_group_exit is true. I believe
that test can now never be true, but it is a bit hard to trace
through and be certain.
Testing signal_group_exit is not expensive, so move the test for
signal_group_exit into the for loop inside of get_signal to ensure
the test is never skipped improperly.
This has been a potential problem since I added the test for
signal_group_exit was added.
Fixes: 35634ffa1751 ("signal: Always notice exiting tasks")
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lkml.kernel.org/r/875yssekcd.fsf_-_@email.froward.int.ebiederm.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions