diff options
author | 2024-09-13 08:47:08 +0000 | |
---|---|---|
committer | 2024-09-30 15:23:44 -0700 | |
commit | 1e53e9d1787babb1544eaec7c7fdcb78a4a20a13 (patch) | |
tree | 73eddd1bf36f961d0877c420416974536599514e /tools/perf/util/session.c | |
parent | perf x86/topdown: Complete topdown slots/metrics events check (diff) | |
download | wireguard-linux-1e53e9d1787babb1544eaec7c7fdcb78a4a20a13.tar.xz wireguard-linux-1e53e9d1787babb1544eaec7c7fdcb78a4a20a13.zip |
perf x86/topdown: Correct leader selection with sample_read enabled
Addresses an issue where, in the absence of a topdown metrics event
within a sampling group, the slots event was incorrectly bypassed as
the sampling leader when sample_read was enabled.
perf record -e '{slots,branches}:S' -c 10000 -vv sleep 1
In this case, the slots event should be sampled as leader but the
branches event is sampled in fact like the verbose output shows.
perf_event_attr:
type 4 (cpu)
size 168
config 0x400 (slots)
sample_type IP|TID|TIME|READ|CPU|IDENTIFIER
read_format ID|GROUP|LOST
disabled 1
sample_id_all 1
exclude_guest 1
------------------------------------------------------------
sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 5
------------------------------------------------------------
perf_event_attr:
type 0 (PERF_TYPE_HARDWARE)
size 168
config 0x4 (PERF_COUNT_HW_BRANCH_INSTRUCTIONS)
{ sample_period, sample_freq } 10000
sample_type IP|TID|TIME|READ|CPU|IDENTIFIER
read_format ID|GROUP|LOST
sample_id_all 1
exclude_guest 1
The sample period of slots event instead of branches event is reset to
0.
This fix ensures the slots event remains the leader under these
conditions.
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Cc: Yongwei Ma <yongwei.ma@intel.com>
Link: https://lore.kernel.org/r/20240913084712.13861-3-dapeng1.mi@linux.intel.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/util/session.c')
0 files changed, 0 insertions, 0 deletions