diff options
| author |   Andrea Righi <andrea.righi@canonical.com> | 2020-04-10 12:02:59 +0200 |
|---|---|---|
| committer |   Shuah Khan <skhan@linuxfoundation.org> | 2020-04-14 09:49:13 -0600 |
| commit | 651e0d881461ab2b1cd5cbec3a642d22fc8d6057 (patch) | |
| tree | 64758fd2c504428a2f3b710350999686cc95ed6d /tools/testing/selftests/kselftest | |
| parent | selftests/harness: fix spelling mistake "SIGARLM" -> "SIGALRM" (diff) | |
| download | wireguard-linux-651e0d881461ab2b1cd5cbec3a642d22fc8d6057.tar.xz wireguard-linux-651e0d881461ab2b1cd5cbec3a642d22fc8d6057.zip | |
kselftest/runner: allow to properly deliver signals to tests
While running seccomp_bpf, kill_after_ptrace() gets stuck if we run it
via /usr/bin/timeout (that is the default), until the timeout expires.
This is because /usr/bin/timeout is preventing to properly deliver
signals to ptrace'd children (SIGSYS in this case).
This problem can be easily reproduced by running:
$ sudo make TARGETS=seccomp kselftest
...
# [ RUN ] TRACE_syscall.skip_a#
not ok 1 selftests: seccomp: seccomp_bpf # TIMEOUT
The test is hanging at this point until the timeout expires and then it
reports the timeout error.
Prevent this problem by passing --foreground to /usr/bin/timeout,
allowing to properly deliver signals to children processes.
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/testing/selftests/kselftest')
| -rw-r--r-- | tools/testing/selftests/kselftest/runner.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh index e84d901f8567..676b3a8b114d 100644 --- a/tools/testing/selftests/kselftest/runner.sh +++ b/tools/testing/selftests/kselftest/runner.sh @@ -33,7 +33,7 @@ tap_timeout() { # Make sure tests will time out if utility is available. if [ -x /usr/bin/timeout ] ; then - /usr/bin/timeout "$kselftest_timeout" "$1" + /usr/bin/timeout --foreground "$kselftest_timeout" "$1" else "$1" fi |