diff options
| author |   Tycho Andersen <tycho@tycho.ws> | 2019-01-18 17:12:17 -0700 |
|---|---|---|
| committer |   Shuah Khan <shuah@kernel.org> | 2019-02-13 08:48:29 -0700 |
| commit | 30d53a5860cf6743db011719d414456b10773d6a (patch) | |
| tree | dcf774369e76e6297a677cc51f3882efc174be59 /tools/testing/selftests | |
| parent | selftests: set NO_NEW_PRIVS bit in seccomp user tests (diff) | |
| download | wireguard-linux-30d53a5860cf6743db011719d414456b10773d6a.tar.xz wireguard-linux-30d53a5860cf6743db011719d414456b10773d6a.zip | |
selftests: unshare userns in seccomp pidns testcases
The pid ns cannot be unshare()d as an unprivileged user without owning the
userns as well. Let's unshare the userns so that we can subsequently
unshare the pidns.
This also means that we don't need to set the no new privs bit as in the
other test cases, since we're unsharing the userns.
Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Shuah Khan <shuah@kernel.org>
Diffstat (limited to 'tools/testing/selftests')
| -rw-r--r-- | tools/testing/selftests/seccomp/seccomp_bpf.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index abff7afd3345..54587b081979 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -3313,7 +3313,7 @@ TEST(user_notification_child_pid_ns) struct seccomp_notif req = {}; struct seccomp_notif_resp resp = {}; - ASSERT_EQ(unshare(CLONE_NEWPID), 0); + ASSERT_EQ(unshare(CLONE_NEWUSER | CLONE_NEWPID), 0); listener = user_trap_syscall(__NR_getpid, SECCOMP_FILTER_FLAG_NEW_LISTENER); ASSERT_GE(listener, 0); @@ -3416,6 +3416,8 @@ TEST(user_notification_fault_recv) struct seccomp_notif req = {}; struct seccomp_notif_resp resp = {}; + ASSERT_EQ(unshare(CLONE_NEWUSER), 0); + listener = user_trap_syscall(__NR_getpid, SECCOMP_FILTER_FLAG_NEW_LISTENER); ASSERT_GE(listener, 0); |