diff options
| author |   Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> | 2023-10-02 12:48:07 +0300 |
|---|---|---|
| committer |   Shuah Khan <skhan@linuxfoundation.org> | 2023-10-13 14:54:04 -0600 |
| commit | beb7f471847663559bd0fe60af1d70e05a1d7c6c (patch) | |
| tree | e4e5b3832992210e336ae9c61febbc1f552a4ff1 /tools | |
| parent | selftests/resctrl: Cleanup benchmark argument parsing (diff) | |
| download | wireguard-linux-beb7f471847663559bd0fe60af1d70e05a1d7c6c.tar.xz wireguard-linux-beb7f471847663559bd0fe60af1d70e05a1d7c6c.zip | |
selftests/resctrl: Fix uninitialized .sa_flags
signal_handler_unregister() calls sigaction() with uninitializing
sa_flags in the struct sigaction.
Make sure sa_flags is always initialized in signal_handler_unregister()
by initializing the struct sigaction when declaring it. Also add the
initialization to signal_handler_register() even if there are no know
bugs in there because correctness is then obvious from the code itself.
Fixes: 73c55fa5ab55 ("selftests/resctrl: Commonize the signal handler register/unregister for all tests")
Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/testing/selftests/resctrl/resctrl_val.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c index 51963a6f2186..01bbe11a8983 100644 --- a/tools/testing/selftests/resctrl/resctrl_val.c +++ b/tools/testing/selftests/resctrl/resctrl_val.c @@ -482,7 +482,7 @@ void ctrlc_handler(int signum, siginfo_t *info, void *ptr) */ int signal_handler_register(void) { - struct sigaction sigact; + struct sigaction sigact = {}; int ret = 0; sigact.sa_sigaction = ctrlc_handler; @@ -504,7 +504,7 @@ int signal_handler_register(void) */ void signal_handler_unregister(void) { - struct sigaction sigact; + struct sigaction sigact = {}; sigact.sa_handler = SIG_DFL; sigemptyset(&sigact.sa_mask); |