From 926631c2012d22ab507ace95b3e5f5621f2c72b7 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 24 Jul 2015 14:05:33 +0300 Subject: ext4: memory leak on error in ext4_symlink() We should release "sd" before returning. Fixes: 0fa12ad1b285 ('ext4: Handle error from dquot_initialize()') Signed-off-by: Dan Carpenter Signed-off-by: Jan Kara --- fs/ext4/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fs/ext4') diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index d3ff83742a33..9f61e7679a6d 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -3084,7 +3084,7 @@ static int ext4_symlink(struct inode *dir, err = dquot_initialize(dir); if (err) - return err; + goto err_free_sd; if ((disk_link.len > EXT4_N_BLOCKS * 4)) { /* -- cgit v1.2.3-59-g8ed1b