From 1340461e5168f8a33b2b3e0ed04557742664bee1 Mon Sep 17 00:00:00 2001 From: Purva Yeshi Date: Tue, 18 Feb 2025 19:40:45 +0530 Subject: af_unix: Fix undefined 'other' error Fix an issue with the sparse static analysis tool where an "undefined 'other'" error occurs due to `__releases(&unix_sk(other)->lock)` being placed before 'other' is in scope. Remove the `__releases()` annotation from the `unix_wait_for_peer()` function to eliminate the sparse error. The annotation references `other` before it is declared, leading to a false positive error during static analysis. Since AF_UNIX does not use sparse annotations, this annotation is unnecessary and does not impact functionality. Reviewed-by: Joe Damato Reviewed-by: Simon Horman Signed-off-by: Purva Yeshi Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20250218141045.38947-1-purvayeshi550@gmail.com Signed-off-by: Jakub Kicinski --- net/unix/af_unix.c | 1 - 1 file changed, 1 deletion(-) (limited to 'net/unix/af_unix.c') diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 34945de1fb1f..319153850be1 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -1508,7 +1508,6 @@ out: } static long unix_wait_for_peer(struct sock *other, long timeo) - __releases(&unix_sk(other)->lock) { struct unix_sock *u = unix_sk(other); int sched; -- cgit v1.2.3-59-g8ed1b