aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorJonathan Rudenberg <jonathan@titanous.com>2016-07-07 07:58:30 -0400
committerJason A. Donenfeld <Jason@zx2c4.com>2016-07-07 13:59:40 +0200
commit349731f002a129306853da78a91cc5d0122edb63 (patch)
treefbb454cf01306b3f5fa0623990c2cdcbf909e6ae
parentrust test: actually use tai64n (diff)
downloadwireguard-monolithic-historical-349731f002a129306853da78a91cc5d0122edb63.tar.xz
wireguard-monolithic-historical-349731f002a129306853da78a91cc5d0122edb63.zip
go test: don't rely on undefined append behavior
-rw-r--r--contrib/external-tests/go/main.go8
1 files changed, 3 insertions, 5 deletions
diff --git a/contrib/external-tests/go/main.go b/contrib/external-tests/go/main.go
index 8e3c195..c1aa293 100644
--- a/contrib/external-tests/go/main.go
+++ b/contrib/external-tests/go/main.go
@@ -118,15 +118,13 @@ func main() {
Dst: net.IPv4(10, 189, 129, 1),
}).Marshal()
binary.BigEndian.PutUint16(pingHeader[2:], uint16(ipv4.HeaderLen+len(pingMessage))) // fix the length endianness on BSDs
- binary.BigEndian.PutUint16(pingHeader[10:], ipChecksum(append(pingHeader, pingMessage...)))
- if err != nil {
- panic(err)
- }
+ pingData := append(pingHeader, pingMessage...)
+ binary.BigEndian.PutUint16(pingData[10:], ipChecksum(pingData))
pingPacket := make([]byte, 13)
pingPacket[0] = 4 // Type: Data
binary.LittleEndian.PutUint32(pingPacket[1:], theirIndex)
binary.LittleEndian.PutUint64(pingPacket[5:], 0) // Nonce
- pingPacket = sendCipher.Encrypt(pingPacket, nil, append(pingHeader, pingMessage...))
+ pingPacket = sendCipher.Encrypt(pingPacket, nil, pingData)
if _, err := conn.Write(pingPacket); err != nil {
log.Fatalf("error writing ping message: %s", err)
}