aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/src/timers.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* timers: include header in right fileJason A. Donenfeld2018-08-091-2/+0
|
* peer: ensure destruction doesn't raceJason A. Donenfeld2018-08-031-26/+34
| | | | | Completely rework peer removal to ensure peers don't jump between contexts and create races.
* peer: simplify rcu reference countsJason A. Donenfeld2018-07-311-1/+4
| | | | | | | Use RCU reference counts only when we must, and otherwise use a more reasonably named function. Reported-by: Jann Horn <jann@thejh.net>
* ratelimiter: prevent init/uninit raceJason A. Donenfeld2018-07-311-0/+2
| | | | | | | Fixes a classic ABA problem that isn't actually reachable because of rtnl_lock, but it's good to be correct anyway. Reported-by: Jann Horn <jann@thejh.net>
* global: use ktime boottime instead of jiffiesJason A. Donenfeld2018-06-231-10/+10
| | | | | | | | Since this is a network protocol, expirations need to be accounted for, even across system suspend. On real systems, this isn't a problem, since we're clearing all keys before suspend. But on Android, where we don't do that, this is something of a problem. So, we switch to using boottime instead of jiffies.
* timers: no need to clear keepalive in persistent keepaliveJason A. Donenfeld2018-05-191-4/+1
| | | | | | | | We do this after sending the keepalive anyway. This is something of a regression, though, since before we'd cancel and then send, but now we send and then cancel, so it introduces a potential race, but hopefully that isn't too big of a deal.
* timers: clear send_keepalive timer on sending handshake responseJason A. Donenfeld2018-05-191-6/+8
| | | | | | We reorganize this into also doing so on sending keepalives itself, which means the state machine is much more consistent, even if this was already implied.
* timers: fix up commentJason A. Donenfeld2018-05-191-2/+2
|
* timers: remove slack_timeJason A. Donenfeld2018-05-191-8/+2
| | | | | It's already done implicitly by recent kernels and it's not adding much here.
* timers: reinitialize state on initJason A. Donenfeld2018-05-181-0/+3
|
* timers: round up instead of down in slack_timeJason A. Donenfeld2018-05-181-2/+2
| | | | | | | | | On systems with a 100hz tick, this causes handshakes to be retried in slightly less than 5 seconds, which means they aren't sent at all. This has the effect of the handshakes entirely stopping their retry cycle until the next data packet is sent. Reported-by: Andrew He <andrewhe@mit.edu>
* global: year bumpJason A. Donenfeld2018-01-031-1/+1
|
* global: add SPDX tags to all filesGreg Kroah-Hartman2017-12-091-1/+4
| | | | | | | | | | | | | It's good to have SPDX identifiers in all files as the Linux kernel developers are working to add these identifiers to all files. Update all files with the correct SPDX license identifier based on the license text of the project or based on the license in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Modified-by: Jason A. Donenfeld <Jason@zx2c4.com>
* global: switch from timeval to timespecJason A. Donenfeld2017-11-221-1/+1
| | | | | | | | | | | | | | | | | | | This gets us nanoseconds instead of microseconds, which is better, and we can do this pretty much without freaking out existing userspace, which doesn't actually make use of the nano/micro seconds field: zx2c4@thinkpad ~ $ cat a.c void main() { puts(sizeof(struct timeval) == sizeof(struct timespec) ? "success" : "failure"); } zx2c4@thinkpad ~ $ gcc a.c -m64 && ./a.out success zx2c4@thinkpad ~ $ gcc a.c -m32 && ./a.out success This doesn't solve y2038 problem, but timespec64 isn't yet a thing in userspace.
* timers: switch to kees' new timer_list functionsJason A. Donenfeld2017-11-011-17/+17
|
* timers: guard entire setting in blockJason A. Donenfeld2017-10-311-4/+6
|
* global: style nitsJason A. Donenfeld2017-10-311-2/+4
|
* global: accept decent check_patch.pl suggestionsJason A. Donenfeld2017-10-311-4/+4
|
* global: add space around variable declarationsJason A. Donenfeld2017-10-031-0/+6
|
* timers: ensure safe timer removalJason A. Donenfeld2017-10-021-12/+17
|
* timers: convert to use netif_runningJason A. Donenfeld2017-09-241-19/+14
|
* queue: entirely rework parallel systemJason A. Donenfeld2017-09-181-8/+11
| | | | | | | | | | This removes our dependency on padata and moves to a different mode of multiprocessing that is more efficient. This began as Samuel Holland's GSoC project and was gradually reworked/redesigned/rebased into this present commit, which is a combination of his initial contribution and my subsequent rewriting and redesigning.
* timers: styleJason A. Donenfeld2017-09-151-1/+1
|
* timers: do not send out double keepaliveJason A. Donenfeld2017-08-051-1/+4
| | | | | | It's possible that a persistent keepalive that comes before a normal keepalive will not invalidate the normal keepalive, and then we'll needlessly send two keepalives.
* timers: rename confusingly named functions and variablesJason A. Donenfeld2017-08-041-9/+9
| | | | Suggested-by: Mathias Hall-Andersen <mathias@hall-andersen.dk>
* receive: move lastminute guard into timer eventJason A. Donenfeld2017-08-041-0/+1
| | | | Suggested-by: Mathias Hall-Andersen <mathias@hall-andersen.dk>
* global: use pointer to net_deviceJason A. Donenfeld2017-07-201-4/+4
| | | | | | DaveM prefers it to be this way per [1]. [1] http://www.spinics.net/lists/netdev/msg443992.html
* timers: queue up killing ephemerals only if not alreadyJason A. Donenfeld2017-05-311-1/+1
|
* timers: reset retry-attempt counter when not retryingJason A. Donenfeld2017-05-311-2/+2
|
* timers: the completion of a handshake also is on key confirmationJason A. Donenfeld2017-05-311-2/+2
|
* timers: rework handshake reply control flowJason A. Donenfeld2017-05-311-9/+8
|
* debug: print interface name in dmesgJason A. Donenfeld2017-05-311-3/+5
|
* timers: fix typo in commentJason A. Donenfeld2017-05-301-1/+1
| | | | Suggested-by: Peter Wu <peter@lekensteyn.nl>
* handshake: process in parallelJason A. Donenfeld2017-05-301-1/+1
|
* data: cleanup parallel workqueue and use two max_activeJason A. Donenfeld2017-04-081-1/+1
|
* timers: elide enable checkJason A. Donenfeld2017-03-141-3/+3
|
* timers: use simpler uninit sync techniqueJason A. Donenfeld2017-02-071-35/+22
|
* timers: use setup_timer macro helperJason A. Donenfeld2017-01-231-20/+5
|
* Update copyrightJason A. Donenfeld2017-01-101-1/+1
|
* peer: don't use sockaddr_storage to reduce memory usageJason A. Donenfeld2016-12-131-3/+3
|
* socket: clear src address when retrying handshakeJason A. Donenfeld2016-12-091-0/+6
|
* timers: add random jitter to handshake retryJason A. Donenfeld2016-12-091-1/+1
|
* headers: cleanup noticesJason A. Donenfeld2016-11-211-1/+1
|
* socket: keep track of src address in sending packetsJason A. Donenfeld2016-11-151-3/+3
|
* send: simplify handshake initiation queueing and introduce lockJason A. Donenfeld2016-11-071-4/+6
|
* timers: take reference like a lookup tableJason A. Donenfeld2016-11-031-23/+18
|
* timers: only have initiator rekeyJason A. Donenfeld2016-10-191-33/+0
| | | | | | | | | If it's time to rekey, and the responder sends a message, the initator will begin the rekeying when sending his response message. In the worst case, this response message will actually just be the keepalive. This generally works well, with the one edge case of the message arriving less than 10 seconds before key expiration, in which the keepalive is not sufficient. In this case, we simply rehandshake immediately.
* timers: always delay handshakes for responderJason A. Donenfeld2016-10-191-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the prior behavior, when sending a packet, we checked to see if it was about time to start a new handshake, and if we were past a certain time, we started it. For the responder, we made that time a bit further in the future than for the initiator, to prevent the thundering herd problem of them both starting at the same time. However, this was flawed. If both parties stopped communicating after 2.2 minutes, and then one party decided to initiate a TCP connection before the 3 minute mark, the currently open session would be used. However, because it was after the 2.2 minute mark, both peers would try to initiate a handshake upon sending their first packet. The errant flow was as follows: 1. Peer A sends SYN. 2. Peer A sees that his key is getting old and initiates new handshake. 3. Peer B receives SYN and sends ACK. 4. Peer B sees that his key is getting old and initiates new handshake. Since these events happened after the 2.2 minute mark, there's no delay between handshake initiations, and problems begin. The new behavior is changed to: 1. Peer A sends SYN. 2. Peer A sees that his key is getting old and initiates new handshake. 3. Peer B receives SYN and sends ACK. 4. Peer B sees that his key is getting old and schedules a delayed handshake for 12.5 seconds in the future. 5. Peer B receives handshake initiation and cancels scheduled handshake.
* timers: move constants to headerJason A. Donenfeld2016-10-191-11/+6
|
* timers: kill half-open handshakes after a whileJason A. Donenfeld2016-10-191-0/+4
|
Copyright © 1996 – 2023 Jason A. Donenfeld. All Rights Reverse Engineered.