From 3167041ad59e53f9a2bfa04f34b9a55be38c2569 Mon Sep 17 00:00:00 2001 From: Julian Orth Date: Thu, 6 Sep 2018 18:45:58 +0200 Subject: device: rename creating_net to transit_net --- src/device.c | 20 ++++++++++---------- src/device.h | 4 ++-- src/netlink.c | 4 ++-- src/socket.c | 8 ++++---- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/device.c b/src/device.c index 877000b..ae4b9ad 100644 --- a/src/device.c +++ b/src/device.c @@ -251,8 +251,8 @@ static void wg_destruct(struct net_device *dev) skb_queue_purge(&wg->incoming_handshakes); free_percpu(dev->tstats); free_percpu(wg->incoming_handshakes_worker); - if (wg->have_creating_net_ref) - put_net(wg->creating_net); + if (wg->have_transit_net_ref) + put_net(wg->transit_net); mutex_unlock(&wg->device_update_lock); pr_debug("%s: Interface deleted\n", dev->name); @@ -304,7 +304,7 @@ static int wg_newlink(struct net *src_net, struct net_device *dev, struct wg_device *wg = netdev_priv(dev); int ret = -ENOMEM; - wg->creating_net = src_net; + wg->transit_net = src_net; init_rwsem(&wg->static_identity.lock); mutex_init(&wg->socket_update_lock); mutex_init(&wg->device_update_lock); @@ -406,13 +406,13 @@ static int wg_netdevice_notification(struct notifier_block *nb, if (action != NETDEV_REGISTER || dev->netdev_ops != &netdev_ops) return 0; - if (dev_net(dev) == wg->creating_net && wg->have_creating_net_ref) { - put_net(wg->creating_net); - wg->have_creating_net_ref = false; - } else if (dev_net(dev) != wg->creating_net && - !wg->have_creating_net_ref) { - wg->have_creating_net_ref = true; - get_net(wg->creating_net); + if (dev_net(dev) == wg->transit_net && wg->have_transit_net_ref) { + put_net(wg->transit_net); + wg->have_transit_net_ref = false; + } else if (dev_net(dev) != wg->transit_net && + !wg->have_transit_net_ref) { + wg->have_transit_net_ref = true; + get_net(wg->transit_net); } return 0; } diff --git a/src/device.h b/src/device.h index b0cbc78..be54d4a 100644 --- a/src/device.h +++ b/src/device.h @@ -40,7 +40,7 @@ struct wg_device { struct net_device *dev; struct crypt_queue encrypt_queue, decrypt_queue; struct sock __rcu *sock4, *sock6; - struct net *creating_net; + struct net *transit_net; struct noise_static_identity static_identity; struct workqueue_struct *handshake_receive_wq, *handshake_send_wq; struct workqueue_struct *packet_crypt_wq; @@ -56,7 +56,7 @@ struct wg_device { unsigned int num_peers, device_update_gen; u32 fwmark; u16 incoming_port; - bool have_creating_net_ref; + bool have_transit_net_ref; }; int wg_device_init(void); diff --git a/src/netlink.c b/src/netlink.c index e17c3e1..8d22230 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -257,7 +257,7 @@ static int wg_get_device_dump(struct sk_buff *skb, struct netlink_callback *cb) genl_dump_check_consistent(cb, hdr); if (!last_peer_cursor) { - if (test_socket_net_capable(wg->creating_net) == 0) { + if (test_socket_net_capable(wg->transit_net) == 0) { if (nla_put_u16(skb, WGDEVICE_A_LISTEN_PORT, wg->incoming_port)) goto out; @@ -351,7 +351,7 @@ static int set_port(struct wg_device *wg, u16 port) struct wg_peer *peer; int ret; - ret = test_socket_net_capable(wg->creating_net); + ret = test_socket_net_capable(wg->transit_net); if (ret) return ret; if (wg->incoming_port == port) diff --git a/src/socket.c b/src/socket.c index 2752335..75e4114 100644 --- a/src/socket.c +++ b/src/socket.c @@ -382,18 +382,18 @@ int wg_socket_init(struct wg_device *wg, u16 port) retry: #endif - ret = udp_sock_create(wg->creating_net, &port4, &new4); + ret = udp_sock_create(wg->transit_net, &port4, &new4); if (ret < 0) { pr_err("%s: Could not create IPv4 socket\n", wg->dev->name); return ret; } set_sock_opts(new4); - setup_udp_tunnel_sock(wg->creating_net, new4, &cfg); + setup_udp_tunnel_sock(wg->transit_net, new4, &cfg); #if IS_ENABLED(CONFIG_IPV6) if (ipv6_mod_enabled()) { port6.local_udp_port = inet_sk(new4->sk)->inet_sport; - ret = udp_sock_create(wg->creating_net, &port6, &new6); + ret = udp_sock_create(wg->transit_net, &port6, &new6); if (ret < 0) { udp_tunnel_sock_release(new4); if (ret == -EADDRINUSE && !port && retries++ < 100) @@ -403,7 +403,7 @@ retry: return ret; } set_sock_opts(new6); - setup_udp_tunnel_sock(wg->creating_net, new6, &cfg); + setup_udp_tunnel_sock(wg->transit_net, new6, &cfg); } #endif -- cgit v1.2.3-59-g8ed1b