From 6214b358a5502915d977d3f850d34bcad71c4cde Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Tue, 4 Sep 2018 10:44:42 -0600 Subject: global: prefer sizeof(*pointer) when possible Suggested-by: Sultan Alsawaf --- src/cookie.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/cookie.c') diff --git a/src/cookie.c b/src/cookie.c index a9f5fda..d073962 100644 --- a/src/cookie.c +++ b/src/cookie.c @@ -68,7 +68,7 @@ void cookie_checker_precompute_peer_keys(struct wireguard_peer *peer) void cookie_init(struct cookie *cookie) { - memset(cookie, 0, sizeof(struct cookie)); + memset(cookie, 0, sizeof(*cookie)); init_rwsem(&cookie->lock); } @@ -120,7 +120,7 @@ enum cookie_mac_state cookie_validate_packet(struct cookie_checker *checker, bool check_cookie) { struct message_macs *macs = (struct message_macs *) - (skb->data + skb->len - sizeof(struct message_macs)); + (skb->data + skb->len - sizeof(*macs)); enum cookie_mac_state ret; u8 computed_mac[COOKIE_LEN]; u8 cookie[COOKIE_LEN]; @@ -156,7 +156,7 @@ void cookie_add_mac_to_packet(void *message, size_t len, struct wireguard_peer *peer) { struct message_macs *macs = (struct message_macs *) - ((u8 *)message + len - sizeof(struct message_macs)); + ((u8 *)message + len - sizeof(*macs)); down_write(&peer->latest_cookie.lock); compute_mac1(macs->mac1, message, len, @@ -181,7 +181,7 @@ void cookie_message_create(struct message_handshake_cookie *dst, struct cookie_checker *checker) { struct message_macs *macs = (struct message_macs *) - ((u8 *)skb->data + skb->len - sizeof(struct message_macs)); + ((u8 *)skb->data + skb->len - sizeof(*macs)); u8 cookie[COOKIE_LEN]; dst->header.type = cpu_to_le32(MESSAGE_HANDSHAKE_COOKIE); -- cgit v1.2.3-59-g8ed1b