wireguard-openbsd/bin/cat, branch master

cat(1): -n flag: correctly enumerate files with more than INT_MAX lines

2020-12-11T05:48:22Z

If we bump 'lines' from an int to an unsigned long long we can trivially support files with more than INT_MAX lines. ok millert@

cat(1): misc. style(9)

2020-12-04T02:25:56Z

- Use getprogname(3) instead of __progname. - Sprinkle in some missing braces. - Prefer err(..., NULL) when malloc(3) fails. - Remove an unnecessary cast to from ssize_t to size_t.

cat(1): simplify argv processing loops

2020-12-04T01:42:05Z

cook_args() and raw_args() do some peculiar things in order to avoid calling cook_buf() and raw_cat(), respectively, in more than one place. The result is a convoluted. If we isolate the special cases from the normal case and just call these functions in multiple places the loops will be easier to read. Three things: 1. Pull the no-args case out of the loop. If *argv is NULL when we get into the argv processing function we just want to operate on the standard input and return early. It makes no sense to handle this case *in* the loop. 2. Isolate the "-" case from the filename case. If *argv is "-" we want to operate on the standard input. We can then do any stdin-specific cleanup within the same branch, which makes it easier to understand both the "-" case and the normal filename case. This also allows us to remove the 'filename' intermediate variable from both argv processing functions. 3. While we're here, use a for-loop and iterate argv in the loop header. Now argv is incremented in one place. ok martijn@

cat(1): remove global 'filename' variable

2020-12-03T22:37:12Z

There is no need for the global filename variable. Both cook_buf() and raw_cat() can accept a filename variable from the caller to use for printing warnings. ok martijn@

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:34:58Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

More whitespace, helps reading

2017-02-19T00:46:57Z

ok ajacoutot@

Delete useless setlocale(3) in src/bin/.

2016-10-19T18:20:25Z

Minor cleanup while here: return from main, static void __dead usage, etc. Based on a patch from Jan Stary . Feedback and OK tb@, OK millert@.

attempt to improve clarity by reducing forward references and more

2016-07-10T00:15:39Z

directly documenting each option's effect.

For -be, indent the $ on blank lines.

2016-07-01T22:40:44Z

Patch from Giles Lean (NetBSD PR bin/4841), tweaked by kleink at NetBSD (rev. 1.17 1998-01-27), version for OpenBSD sent in by Sevan Janiyan . OK deraadt@

replace setbuf with setvbuf, from Frederic Nowak

2015-11-04T21:28:01Z