wireguard-openbsd/bin/csh/dir.c, branch jd/simplify-queueing

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:34:58Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

Fix some minor issues found by coverity.

2018-10-24T06:01:03Z

OK millert@ and miko@

If getcwd() fails in dinit(), the stat buffer 'swd' is used

2018-09-19T18:55:33Z

uninitialized by the else clause. Since it is used in both clauses we should perform the stat before the if(). However, fixing this causes 'cp' to be unitialized in some case so initialize cp to NULL and move the "cp == NULL" check out of the first if() clause now that it can be true in either case. OK miko@ deraadt@

Replace handrolled xfree() function by directly using free(3)

2015-12-26T13:48:38Z

OK mmcc@

delete tons more casts

2015-02-08T06:09:50Z

delete many more ptr_t casts

2015-02-08T05:51:37Z

Replace with and other less dirty headers where

2015-01-16T06:39:28Z

possible. Annotate lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.

2014-10-16T19:43:31Z

ok deraadt

If a constant string needs a name, use a static const array instead

2014-07-12T02:47:51Z

of a pointer or non-const array, as that minimizes the symbols, maximizes the placement into read-only memory, and avoids warnings from gcc -Wformat=2 when they're used as format strings.

correct readlink termination. from Doug Hogan

2014-07-11T07:54:04Z