wireguard-openbsd/bin/ksh, branch jd/simplify-queueing

Fix the exit code when eval()uating a || compound list, it would

2020-05-22T07:50:07Z

terminate the shell when running under -e. See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=269067 and Bug reported including fix by Leah Neukirchen, Thanks! ok millert@

Use proper function pointer type instead of void *

2020-05-08T14:30:42Z

Mixing up function and void pointers isn't defined by POSIX or the C standard. POSIX only specifies that casting the result of dlsym(3) to an appropriate function pointer works. Avoid all this by using a typedef. from Michael Forney, ok tb@

Enforce that TMOUT is an integer literal to prevent command execution from

2020-02-21T18:21:23Z

the environment at shell initialization time. During startup, ksh calls 'eval typeset -i TMOUT="${TMOUT:-0}"'. which allows command injection via arithmetic expansion, e.g., by setting TMOUT to 'x[`/bin/echo Hi >&2`]'. Problem noted by Andras Farkas and tj, inspired by a similar issue in AT&T's ksh. Tested in snaps for two weeks. "go for it" deraadt

some corrections to CDPATH;

2019-11-26T22:49:01Z

from chohag

No need for as writev(2) isn't used any more.

2019-10-27T15:02:19Z

Don't fail hard if we can't preallocate history storage.

2019-10-27T14:58:52Z

Using alloc.c for the history array brings no value and prevents easy handling of memory shortage. Switch to plain reallocarray and keep running if HISTSIZE is too big. The allocation is still done upfront with no sanity checking, it would probably be nicer to allocate space as needed. Issue reported by thomas@habets.se who suggested a different approach.

Add #include for mkstemp.

2019-07-24T14:33:16Z

Spotted by maya@netbsd ok deraadt@

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:34:58Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

Some asprintf() calls were checked < 0, rather than the precise == -1.

2019-06-27T18:03:36Z

ok millert nicm tb, etc

Fix spelling

2019-06-24T15:05:17Z