wireguard-openbsd/bin/sleep, branch jd/simplify-queueing

sleep(1): style(9) and other dusting

2020-02-25T15:46:15Z

- Sort includes alphabetically - Sort prototypes alphabetically - Sort stack variables by size - Add missing braces to the getopt(3) loop - Be explicit: there is *one* argument, so use argv[0], not *argv - If nanosleep(2) somehow fails, say that "nanosleep" failed when we err(3) - Remove extra parentheses from the return statement - De-(void) the obvious fprintf(3) in usage() - __progname -> getprogname(3) - POSIX 1003.2 has long since become POSIX.1 - Remove an ARGUSED linter comment - stdio(3) flushing is not the only potential issue with an exit(3) from a signal handler. Just note that exit(3) isn't safe and leave it at that.

sleep(1): simplify argument parsing

2019-07-01T00:01:34Z

- No need for intermediate variables, just build the timespec directly - Use for-loops so we modify "cp" on a single line in each loop - Parse subseconds with one loop: less code, easier to read, etc. - Improve the subsecond parsing comment: make our intent really obvious ok schwarze@

Revert nanosleep(2) loop introduced in v1.25.

2019-01-10T16:41:10Z

Now that nanosleep(2) handles the full input range transparently there is no longer a 100 million second upper bound and we can remove this loop. ok phessler@ jca@ visa@

Print strtonum(3)-style error messages on invalid numeric input.

2018-02-04T02:18:15Z

More informative than the usage message. While here, no need to return EINVAL: just return 1 if we overflow. ok jca@ schwarze@

Extend range for seconds from 100 million to upper bound of time_t.

2018-02-02T16:46:37Z

Makes us compliant with POSIX.1-2008, which requires that sleep(1) support up to 2147483647 seconds. Bounced off of tb@ and jca@. ok tb@ millert@ jca@

Add, correct, and improve HISTORY sections.

2016-08-16T18:51:25Z

From Sevan Janiyan . Verified using http://minnie.tuhs.org/.

Don't return errno from main()

2015-10-11T20:17:49Z

ok beck@ doug@ deraadt@ tedu@

Change all tame callers to namechange to pledge(2).

2015-10-09T01:37:06Z

So you'd love me to say sleep() can be tighter than tame "stdio". OK,

2015-10-03T03:10:38Z

there is that pesky usage message... We could tame "something" in the non-usage codepath.. but pop quiz, anyone know what happens after main returns or if exit(3) is called? atexit completion.. our atexit is very paranoid with structure management and uses mprotect. So current minimum a normal program needs is tame "malloc". tame "stdio" done before the usage codepath splits is just as good; tame placement before getopt provides a strong hint about program behaviour. I am still hoping someone comes up with a nice solution for atexit, or a nice tame subset between "" (pure computation) and "malloc". Ideas have been floated to expose "self", but it lacks mprotect also, and should continue to lack it (see the ssh tame sandbox).

sleep doesn't benefit from setting locale. we always want to parse numbers

2015-09-22T15:37:06Z

as our forefathers did, and it doesn't print any error messages in need of translation. ok stsp