wireguard-openbsd/games/factor, branch master WireGuard implementation for the OpenBSD kernel https://git.zx2c4.com/wireguard-openbsd/atom/games/factor?h=master 2016-09-01T10:48:38Z In 32 bits sqrt(val) + 1 can overflow, so some big primes still 2016-09-01T10:48:38Z tb tb@openbsd.org 2016-09-01T10:48:38Z urn:sha1:2fde6ebb66f78fd6f60bc95ebe1ffc19aeb2845d aren't recognized as such, for example 18446744073709551577 given in the commit message of factor.c r1.7 from NetBSD. Move the return type of usqrt() from u_int32_t to u_int64_t. ok guenther, tom, otto Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull. 2016-08-14T18:34:48Z guenther guenther@openbsd.org 2016-08-14T18:34:48Z urn:sha1:f5cc6d1c3ee3423fc1397948e8c55d5721fdff84 Fix a type mismatch in ftp's "page" command and could make transfers restart at the wrong position. ok and a ull->ll tweak from natano@, ok tedu@ Instead of using the floating point square root, use an integer version 2016-07-11T18:30:21Z tb tb@openbsd.org 2016-07-11T18:30:21Z urn:sha1:62b9314c61c9071ddbc1ae28aea86872b82251e0 of the Newton method from ping.c. Fixes a rounding issue that caused failure to factor numbers close to 2^64, e.g. 18446744030759878681. While there, fix an off by one error that caused 4295360521 to be reported as a prime. Issues reported by Paul Stoeber and Michael Bozon. ok tedu, deraadt for some time now mandoc has not required MLINKS to function 2016-03-30T06:38:40Z jmc jmc@openbsd.org 2016-03-30T06:38:40Z urn:sha1:faa33665ab2c5a685369c10172c1a3d7555eb253 correctly - logically complete that now by removing MLINKS from base; authors need only to ensure there is an entry in NAME for any function/ util being added. MLINKS will still work, and remain for perl to ease upgrades; ok nicm (curses) bcook (ssl) ok schwarze, who provided a lot of feedback and assistance ok tb natano jung - General changes: 2016-03-07T12:07:55Z mestre mestre@openbsd.org 2016-03-07T12:07:55Z urn:sha1:6fa5e1da3490487b9d3a614457ba0b7c041eb1ac - Remove -? from getopt(3) options, but still keep (or add) -h where applicable - Replace hardcoded program strings by getprogname(3) - Specific changes: - atc(6): this used -? and -u for usage(), remove both from game and manpage - bcd(6): use __progname instead of getprogname(3), no need to include stdlib.h - hunt(6): replace fputs(3) by fprintf(3) OK tb@ after his suggestions Some basic code maintenance in games/ 2016-01-07T16:00:31Z tb tb@openbsd.org 2016-01-07T16:00:31Z urn:sha1:17641e3181064a4b256bd1af9f64d90af0ac5a36 - in main() replace exit with return - drop some /* NOTREACHED */ lint comments along the way. - make more use of standard CFLAGS, esp. -Wimplicit-function-declaration - add and sort some headers when needed - add straightforward pledges to some programs used at compile time discussed with and ok mestre@ More headers removal and sorted the remaining alphabetically. 2016-01-04T11:58:35Z mestre mestre@openbsd.org 2016-01-04T11:58:35Z urn:sha1:bdf3894f0c761055c5cbceaae3fb7c235dd3294c Most noticeable that were removed are sys/types.h which will be included from stdlib.h and in turn also brings along sys/cdefs.h. The other one is limits.h that was used with the old idiom (denom * random() / LONG_MAX), although it was only removed were applicable (some files still need that header). OK tb@ Michal Mazurek pointed out on tech@ that the factor.6 manual needs a bit 2015-12-30T14:07:53Z tb tb@openbsd.org 2015-12-30T14:07:53Z urn:sha1:d9138424f2530bdda04da8079b73144c68a3f5b2 of clarification. Thus, express the description both more concisely and more precisely. Drop details about spaces in the output formatting. While there, update the corresponding comment in the source code. With input from jmc@ and mestre@; detailed discussion with sobrado@. ok sobrado@ Declare usage() functions as __dead void, if they don't return, on games section. 2015-12-25T20:59:09Z mestre mestre@openbsd.org 2015-12-25T20:59:09Z urn:sha1:f0628b46ae621bae7650f74df86c15fcd5e2698f Found another one in arithmetic(6) which also didn't return, and removed a function from number(6) which is not used anymore. OK tb@ Cast isblank()'s argument to unsigned char. 2015-10-24T17:31:00Z mmcc mmcc@openbsd.org 2015-10-24T17:31:00Z urn:sha1:8059d61abfef30f2c788403270586fcd548133fd ok guenther@