wireguard-openbsd/lib/libc/gen/fts.c, branch jd/queueboosts

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

recallocarray() the string buffer, to avoid leaving such contents

2017-03-17T15:14:40Z

around in the address space. Don't bother doing so for the buffer which contains aslr'd pointers... ok millert

Style improvement, no functional change.

2017-02-15T15:58:40Z

As reported by Yuri Pankov, some versions of GCC whine that "tmp" might be used uninitialized in fts_open(3). Clearly, that cannot actually happen, but explicitly setting it to NULL is safer anyway. While here, rename the badly named variable "tmp" and make the inner "if" easier to understand. Feedback and OK guenther@

Delete casts to off_t and size_t that are implied by assignments

2016-09-21T04:38:56Z

or prototypes. Ditto for some of the char* and void* casts too. verified no change to instructions on ILP32 (i386) and LP64 (amd64) ok natano@ abluhm@ deraadt@ millert@

fts_open() requires that the list passed as argument to contain at least

2016-06-28T17:21:48Z

one path. When the list is empty (contain only a NULL pointer), return EINVAL instead of pretending to succeed, which will cause a NULL pointer deference in a later fts_read() call. From FreeBSD.

Do not return an error in fts_open(3) if one of the paths in argv

2016-06-28T17:12:29Z

is empty. Otherwise, programs using fts(3) will report an error if one of the paths is empty instead of just treating it as a non-existent file. OK guenther@

delete old lint ARGSUSED comments

2015-11-01T03:45:28Z

remove null check before free. from Michael McConville

2015-09-14T16:09:13Z

ok semarie

Wrap and so that internal calls to fts_*() go direct and

2015-09-12T13:32:24Z

fts_*(), ftw(), and nftw() are weak symbols

Move to the universe.

2015-01-16T16:48:51Z

review by millert, binary checking process with doug, concept with guenther