wireguard-openbsd/lib/libc/gen/getusershell.c, branch jd/queueboosts WireGuard implementation for the OpenBSD kernel https://git.zx2c4.com/wireguard-openbsd/atom/lib/libc/gen/getusershell.c?h=jd%2Fqueueboosts 2019-12-10T02:35:16Z Remove includes that are no longer neeed after tedu's simplification. 2019-12-10T02:35:16Z millert millert@openbsd.org 2019-12-10T02:35:16Z urn:sha1:10db3397df717fb38d285c5b7af079e997bd034c OK jca@ rewrite guts of getusershell() to avoid possibility of overflow. 2015-12-08T16:28:26Z tedu tedu@openbsd.org 2015-12-08T16:28:26Z urn:sha1:7a4171b0ac9426e73c417e6fdadbbc40d835f400 instead of trying to allocate "just enough" memory based on the size of the file (which is mostly comments, in fact), allocate memory on demand. i.e., save memory by wasting it. also be a little stricter about parsing. after discussion with tobias. (with a bug fix from patrick keshishian) descended from bug glibc bug 18660 via tobias. remove null check before free. from Michael McConville 2015-09-14T16:09:13Z tedu tedu@openbsd.org 2015-09-14T16:09:13Z urn:sha1:183195fb2f7518b2cd4510b5b8f442268aefa790 ok semarie SIZE_MAX is standard, we should be using it in preference to the 2015-02-06T23:21:58Z millert millert@openbsd.org 2015-02-06T23:21:58Z urn:sha1:4239b8225fa4f64aecb5a0fe486abd01f9e64ae2 obsolete SIZE_T_MAX. OK miod@ beck@ When fopen()ing internal to libc (the API doesn't support the use 2014-09-15T06:15:48Z guenther guenther@openbsd.org 2014-09-15T06:15:48Z urn:sha1:241db05998f1091df691c528a16b6ca3ab8719d3 of the resulting FILE *), then pass fopen() the 'e' mode letter to mark it close-on-exec. ok miod@ Fix one more off-by-one (making it an off-by-two): 2014-01-19T21:01:06Z tobias tobias@openbsd.org 2014-01-19T21:01:06Z urn:sha1:f0b13b6daea08b8d3c68a5c5569f8dfa1fc77095 1. integer division can give an off-by-one (like 2/3 = 0 for calloc) 2. ending the shells array with NULL takes space, too ok millert@ Fix off-by-one on specially crafted /etc/shells file. 2014-01-17T20:51:54Z tobias tobias@openbsd.org 2014-01-17T20:51:54Z urn:sha1:74f2eca76a12567ff995c2d1b2adc88e48bef133 ok gilles@, millert@ most obvious unsigned char casts for ctype 2013-11-24T23:51:28Z deraadt deraadt@openbsd.org 2013-11-24T23:51:28Z urn:sha1:dfe5467e3c6b93ccc8be21818dca4babdc79fd90 ok jca krw ingo Use PATH_MAX, NAME_MAX and LOGIN_NAME_MAX not MAXPATHNAMELEN, 2013-09-30T12:02:30Z millert millert@openbsd.org 2013-09-30T12:02:30Z urn:sha1:69245ebdc94b271c4e1a54cf0b76d96467dc638e MAXNAMLEN or MAXLOGNAME where possible. OK deraadt@ range check st_size before calling calloc() 2012-04-06T20:54:41Z deraadt deraadt@openbsd.org 2012-04-06T20:54:41Z urn:sha1:b5ce4011f41afcf3a7516c6276fd41377f0fc683 ok millert