wireguard-openbsd/lib/libc/gen/nlist.c, branch jd/queueboosts

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

The fd used by nlist() isn't application visible, so mark it close-on-exec

2019-05-13T17:18:10Z

to avoid leaking it ok deraadt@

Use instead of

2017-10-27T16:47:08Z

ok jasper@, jca@, deraadt@

gcc says "if you define labels and don't use them, I will whine."

2016-12-25T20:30:41Z

ok tom@

Delete casts to off_t and size_t that are implied by assignments

2016-09-21T04:38:56Z

or prototypes. Ditto for some of the char* and void* casts too. verified no change to instructions on ILP32 (i386) and LP64 (amd64) ok natano@ abluhm@ deraadt@ millert@

Verify that the section header size supplied in the ELF header is what

2015-12-29T22:31:21Z

we expect it to be. This prevents out-of-bounds access or excessive memory allocation on a malformed ELF header. Found by Serguey Parkhomovsky with AFL. Improved by and ok kettenis@

Check file sizes only for regular files. The current code breaks savecore

2015-10-16T16:54:38Z

due to its kvm handling. ok deraadt

Merge nlist out of boundary access fix with other nlist implementations.

2015-10-16T13:54:45Z

While at it, merge style and typo fixes back into nlist(3), too. ok deraadt, jsing, millert

Validate parsed ELF values to prevent out of boundary accesses.

2015-10-16T07:40:12Z

While at it, return proper return value when encountering a stripped binary. Instead of -1 (illegal file), it should be the amount of symbols that were tried to be resolved. ok millert

__fdnlist() is exported for libkvm, but the internal call can go direct

2015-10-04T06:59:57Z