wireguard-openbsd/lib/libc/locale, branch jd/queueboosts

snprintf/vsnprintf return < 0 on error, rather than -1.

2019-07-03T03:24:01Z

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

POSIX.1-2008 TC3 is going to clarify how newlocale(3) uses oldloc.

2019-06-25T17:40:24Z

Explicitly state that our implementation now complies with the stricter requirements of TC3 because the newlocale(3) in old OpenBSD releases only complied with the weaker requirements of the old text of the standard. The complaints from our users resulted in both our implementation and the standard being improved. For details, see: http://austingroupbugs.net/view.php?id=1243#c4347

Copy categories outside "mask" from "oldloc" to the new locale object.

2019-03-29T12:34:44Z

While POSIX appears to allow the old behaviour of ignoring "oldloc", Ted and Karl convinced me that is a bug in the spec and the Austin group almost certainly intended to require the new behaviour. Anyway, compatibility strongly suggests the new behaviour because most (or maybe even all?) other systems do not ignore "oldloc", and some software appears to depend on the copying from "oldloc" to the new locale. Issue analyzed and reported by Karl Williamson with support from the Perl 5 community. This final diff is similar to two earlier diffs from Ted, but handles invalid input in a mode robust way. OK tedu@.

Improve the description of locale dependency:

2019-01-18T07:43:36Z

* mention LC_COLLATE; * clarify that all these functions are infested, including the *_l() versions; * avoid ENVIRONMENT, these functions don't inspect it; * and point to the C library functions that change the locale. OK millert@

For all functions known to be infected by LC_NUMERIC, add short

2019-01-16T12:55:49Z

CAVEATS pointing to the new CAVEATS section in setlocale(3). Make those in wprintf(3) and wscanf(3) more concise since duplicate information is a bad idea. Incompleteness of information originally pointed out by millert@. OK millert@

Warn against using any categories but LC_CTYPE in setlocale(3) and

2019-01-13T22:57:08Z

list many (hopefully the most important) functions affected by the locale, such that the CAVEATS sections in individual manual pages can be kept shorter in the future; basic idea from millert@; feedback and OK jmc@; OK deraadt@.

mention which locale categories this is related to, and add SEE ALSO

2018-04-04T15:04:37Z

add SEE ALSO

2018-04-04T14:57:51Z

Split the useless localeconv(3) function out of the important

2018-04-04T14:53:02Z

setlocale(3) manual page, such that the latter becomes easier to read. No text change.