wireguard-openbsd/lib/libc/stdlib/getopt_long.c, branch jd/queueboostsWireGuard implementation for the OpenBSD kernelhttps://git.zx2c4.com/wireguard-openbsd/atom/lib/libc/stdlib/getopt_long.c?h=jd%2Fqueueboosts2020-05-27T22:25:09ZThis patch fixes one bug and one instance of undesirable behaviour.2020-05-27T22:25:09Zschwarzeschwarze@openbsd.org2020-05-27T22:25:09Zurn:sha1:0025f5bb9c9be650004db9e38ab09eea44e2b392
The bug, present since 4.4BSD, was that a trailing dash in an option
group, when the dash is not permitted as an option letter, resulted
in the whole option group being returned as an argument, even though
the previous option in the group was already parsed as an option:
OPTS=abc ./getopt-test -a- -c arg ===>> OPT(a)ARG(-a-)ARG(-c)ARG(arg).
Instead, treat the dash as an invalid option and continue parsing
options: ===>> OPT(a)ERR(?-)OPT(c)ARG(arg).
The undesirable behaviour was that allowing the dash as an option
letter only allowed isolated dashes ("-") and trailing dashes in
groups ("-a-"), but neither middle dashes in groups ("-a-b"), even
though that already partially worked in 4.4BSD, nor leading dashes
in groups ("--a"), even though that works on all other BSDs and on
glibc. Also, while POSIX does not require that the dash can be
used as an option letter at all, arguably, it encourages that letters
either be fully supported or not supported at all. It is dubious
whether supporting an option letter in some positions but not in
others can be considered conforming.
This patch makes OpenBSD behaviour identical to FreeBSD and NetBSD,
improves compatibility with glibc (except that glibc does not support
isolated "-"), improves compatibility with DragonFly (except that
DragonFly is buggy when the dash option letter can take an optional
argument but that argument is not present), improves compatibility
with Illumos and Solaris 11 (except those do not support "-" and
mishandle "--a"), and restores 4.4BSD behaviour for "-a-b". In no
respect i'm aware of is compatibility with any other systems reduced.
For the full rationale, see my mail to tech@
on 30 Mar 2020 14:26:41 +0200.
Part of the problem was originally reported by an anonymous coward
on tech@ on 12 Mar 2020 03:40:24 +0200, additional analysis was
contributed by martijn@, and then the OP sent the final version of
the patch i'm now committing on 17 Mar 2020 19:17:56 +0200.
No licensing problem here because after the commit, the file does
not contain a single word written by the OP. Also, the OP told me
in private mail that he intends to publish the patch under the ISC
license already contained in the file and that he wishes to be known
by the pseudonym "0xef967c36".
OK martijn@, and no objection when shown on tech@,
but commit delayed to stay clear of the release.
"eventually" came and went back in 2004.2020-03-30T12:52:58Zmartijnmartijn@openbsd.org2020-03-30T12:52:58Zurn:sha1:54774e4694bc26372e6c6c209aa4755f3d0c4c36
OK schwarze@
I am retiring my old email address; replace it with my OpenBSD one.2019-01-25T00:19:25Zmillertmillert@openbsd.org2019-01-25T00:19:25Zurn:sha1:bf198cc6eba0ca1f6d79f71e8e2243d386241fa8Eliminate the last of the LINTEDn and PRINTFLIKEn comments. In one2015-10-01T02:32:07Zguentherguenther@openbsd.org2015-10-01T02:32:07Zurn:sha1:9d9553bd2d73b47a1e6c954c7538bf7cd6b06ea5
case, by deleting some useless '& of an array' we also eliminate the need
for the casts which prompted the original lint warnings
ok deraadt@
Don't wrap initialized variables: binutils appears to be mishandling them2015-09-19T04:02:21Zguentherguenther@openbsd.org2015-09-19T04:02:21Zurn:sha1:14437dc7d7f86aaf2122120902dad7bca8962f63
on arm and m88k
problems with optind observed by jsg@
Wrap <getopt.h> to make the functions weak and make access to the initialized2015-09-12T14:48:14Zguentherguenther@openbsd.org2015-09-12T14:48:14Zurn:sha1:0efd2def317b9301899bd5f4b4036505346a77ee
variables go direct. (Common variables cannot be aliased.)
Fix parsing of ambiguous options, the whole loop must be processed.2013-06-08T22:47:56Zmillertmillert@openbsd.org2013-06-08T22:47:56Zurn:sha1:009fd0113f45a5878b44fabb6589b78cfe4a3a1b
From FreeBSD. OK miod@
Fix PR 6267: recheck POSIXLY_CORRECT each time getopt_long() starts a new2011-03-05T22:10:11Zguentherguenther@openbsd.org2011-03-05T22:10:11Zurn:sha1:ebb4ed69e98da281c0adb4141a4d2f42eeae3ce8
argv and don't suppress the handling of leading '-' in optstring when
POSIXLY_CORRECT is set.
Based on patch from Eric Blake.
ok and manpage update from millert@, manpage ok jmc@
getopt_long.c replaced getopt.c 6+ years ago; we can retire2010-07-22T19:31:53Zblambertblambert@openbsd.org2010-07-22T19:31:53Zurn:sha1:aa61a0bc07da61e0481789c71dd03290ea337872
the REPLACE_GETOPT macro, at long last
ok millert@
Add parentheses to avoid warning:2007-10-31T12:34:57Zchlchl@openbsd.org2007-10-31T12:34:57Zurn:sha1:9f3012680dae2b5d7842256f324c96a5ec75265d
"suggest parentheses around && within ||"
ok millert@