wireguard-openbsd/lib/libc/stdlib, branch master WireGuard implementation for the OpenBSD kernel https://git.zx2c4.com/wireguard-openbsd/atom/lib/libc/stdlib?h=master 2021-03-18T11:16:58Z Type-cast getpagesize() from int to size_t for the comparison with d. 2021-03-18T11:16:58Z claudio claudio@openbsd.org 2021-03-18T11:16:58Z urn:sha1:2cb7cdfc213f61a57def00eb11d6dce9bd9d43ed getpagesize() will only return positive numbers (there is no negative page size system) and it can not fail. Should fix some compiler warnings seen in -portable projects. OK otto@ Change the implementation of the malloc cache to keep lists of 2021-03-09T07:39:28Z otto otto@openbsd.org 2021-03-09T07:39:28Z urn:sha1:c9c2a8bced2637f49891a0cc87ce149229a8c70e regions of a given size. In snaps for a while, committing since no issues were reported and a wider audience is good. ok deraadt@ - Make use of the fact that we know how the chunks are aligned, and 2021-02-25T15:20:18Z otto otto@openbsd.org 2021-02-25T15:20:18Z urn:sha1:19aed9fc1bc211bc77ba2c7c4b875067ff9ef027 write 8 bytes at the time by using a uint64_t pointer. For an allocation a max of 4 such uint64_t's are written spread over the allocation. For pages sized and larger, the first page is junked in such a way. - Delayed free of a small chunk checks the corresponiding way. - Pages ending up in the cache are validated upon unmapping or re-use. In snaps for a while Some people still argue that rand(3) and random(3) have suitable deterministic 2021-02-12T17:03:51Z deraadt deraadt@openbsd.org 2021-02-12T17:03:51Z urn:sha1:70d9094f4044ec4d667009ef66d835cce8e9a22a use cases, so explain the situation a bit more. Since the 80's, I estimate around 5 algorithm changes, so any chosen seed is unrepeatable UB. +The deterministic sequence algorithm changed a number of times since +original development, is underspecified, and should not be relied upon to +remain consistent between platforms and over time. ok jmc kettenis mapalign() only handles allocations >= a page; problem found by and ok semarie@ 2020-11-23T15:42:11Z otto otto@openbsd.org 2020-11-23T15:42:11Z urn:sha1:3e142b5f5cb35c8cab23ac0d23ae9bf7223127a6 make fixed-sized fixed-value mib[] arrays be const 2020-10-12T22:08:32Z deraadt deraadt@openbsd.org 2020-10-12T22:08:32Z urn:sha1:87afc19ed9256ae3cb7c5266911abf02218c2a35 ok guenther tb millert As noted by tb@ previous commit only removed an unused fucntion. 2020-10-09T16:01:48Z otto otto@openbsd.org 2020-10-09T16:01:48Z urn:sha1:8d0b0dbd89d917f475263e4c5c2c9581814d6b2d So redo previous commit properly: Use random value for canary bytes; ok tb@. Use random value for canary bytes; ok tb@ 2020-10-06T06:31:14Z otto otto@openbsd.org 2020-10-06T06:31:14Z urn:sha1:321ee9bbf9f687cededae2103aae9f340ecd1895 For page-sized and larger allocations do not put the pages we're 2020-09-06T06:41:03Z otto otto@openbsd.org 2020-09-06T06:41:03Z urn:sha1:ee0eab5e912b130fbf155b303019f57dccd62a6b shaving off into the cache but unamp them. Pages in the cache get re-used and then a future grow of the first allocation will be hampered. Also make realloc a no-op for small shrinkage. ok deraadt@ This patch fixes one bug and one instance of undesirable behaviour. 2020-05-27T22:25:09Z schwarze schwarze@openbsd.org 2020-05-27T22:25:09Z urn:sha1:0025f5bb9c9be650004db9e38ab09eea44e2b392 The bug, present since 4.4BSD, was that a trailing dash in an option group, when the dash is not permitted as an option letter, resulted in the whole option group being returned as an argument, even though the previous option in the group was already parsed as an option: OPTS=abc ./getopt-test -a- -c arg ===>> OPT(a)ARG(-a-)ARG(-c)ARG(arg). Instead, treat the dash as an invalid option and continue parsing options: ===>> OPT(a)ERR(?-)OPT(c)ARG(arg). The undesirable behaviour was that allowing the dash as an option letter only allowed isolated dashes ("-") and trailing dashes in groups ("-a-"), but neither middle dashes in groups ("-a-b"), even though that already partially worked in 4.4BSD, nor leading dashes in groups ("--a"), even though that works on all other BSDs and on glibc. Also, while POSIX does not require that the dash can be used as an option letter at all, arguably, it encourages that letters either be fully supported or not supported at all. It is dubious whether supporting an option letter in some positions but not in others can be considered conforming. This patch makes OpenBSD behaviour identical to FreeBSD and NetBSD, improves compatibility with glibc (except that glibc does not support isolated "-"), improves compatibility with DragonFly (except that DragonFly is buggy when the dash option letter can take an optional argument but that argument is not present), improves compatibility with Illumos and Solaris 11 (except those do not support "-" and mishandle "--a"), and restores 4.4BSD behaviour for "-a-b". In no respect i'm aware of is compatibility with any other systems reduced. For the full rationale, see my mail to tech@ on 30 Mar 2020 14:26:41 +0200. Part of the problem was originally reported by an anonymous coward on tech@ on 12 Mar 2020 03:40:24 +0200, additional analysis was contributed by martijn@, and then the OP sent the final version of the patch i'm now committing on 17 Mar 2020 19:17:56 +0200. No licensing problem here because after the commit, the file does not contain a single word written by the OP. Also, the OP told me in private mail that he intends to publish the patch under the ISC license already contained in the file and that he wishes to be known by the pseudonym "0xef967c36". OK martijn@, and no objection when shown on tech@, but commit delayed to stay clear of the release.