wireguard-openbsd/lib/libcrypto/buffer/buffer.c, branch jd/queueboosts WireGuard implementation for the OpenBSD kernel https://git.zx2c4.com/wireguard-openbsd/atom/lib/libcrypto/buffer/buffer.c?h=jd%2Fqueueboosts 2017-05-02T03:59:44Z use freezero() instead of memset/explicit_bzero + free. Substantially 2017-05-02T03:59:44Z deraadt deraadt@openbsd.org 2017-05-02T03:59:44Z urn:sha1:7de8a6843ca16b4f1c9d2a7eab4c71e8af96a4e6 reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck Simplify/clean up BUF_MEM_grow_clean(). 2017-04-09T15:06:20Z jsing jsing@openbsd.org 2017-04-09T15:06:20Z urn:sha1:7f2c4a2bceadf5ab1cfcfc982ac2f57552b4a1e9 ok beck@ With recallocarray() BUF_MEM_grow() is essentially the same as 2017-04-09T15:03:54Z jsing jsing@openbsd.org 2017-04-09T15:03:54Z urn:sha1:027ccf5329c0a626d5f824374ef6ff2fa3f4b437 BUF_MEM_grow_clean() (the only difference is clearing on internal down sizing), so make it a wrapper. ok beck@ deraadt@ Convert BUF_MEM_grow() and BUF_MEM_grow_clean() to recallocarray(), 2017-03-16T13:29:56Z jsing jsing@openbsd.org 2017-03-16T13:29:56Z urn:sha1:33497392331332de6a8976beabee1bb694603e0f ensuring that the buffer contents are zeroed on allocation and not leaked when resizing. It is worth noting that BUF_MEM_grow_clean() already did this manually by avoiding realloc(). ok beck@ inoguchi@ Use calloc() instead of malloc() followed by manually zeroing fields. 2017-03-16T13:15:06Z jsing jsing@openbsd.org 2017-03-16T13:15:06Z urn:sha1:e21846dbfd5ef8d7f4278a6ea76ba27f90b68cdb ok beck@ inoguchi@ Send the function codes from the error functions to the bit bucket, 2017-01-29T17:49:22Z beck beck@openbsd.org 2017-01-29T17:49:22Z urn:sha1:5067ae9f807f8af9e6350e51e6a54619386c06ba as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:47Z jsing jsing@openbsd.org 2014-07-11T08:44:47Z urn:sha1:b6ab114e77db2581d5bda2ca4b0aa0d68b2e0f90 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Stop including standard headers via cryptlib.h - pull in the headers that 2014-07-10T13:58:21Z jsing jsing@openbsd.org 2014-07-10T13:58:21Z urn:sha1:a8913c44aee6c78b4770e56ab6afb429afabee6d are needed in the source files that actually require them. ok beck@ miod@ Replace memset(a, 0, ...); free(a); by explicit_bzero(a, ...); free(a); in 2014-07-09T16:51:09Z miod miod@openbsd.org 2014-07-09T16:51:09Z urn:sha1:7588eaaf30efec0015fc0920a451ac65df2c2c35 fear a smartass-optimizing compiler decides memset is useless immediately before free(). ok jsing@ deraadt@ tedu@ tags as requested by miod and tedu 2014-06-12T15:49:27Z deraadt deraadt@openbsd.org 2014-06-12T15:49:27Z urn:sha1:c3d6a26af7455bccce87985ff78ef0efc39b65e1