wireguard-openbsd/lib/libedit/chared.c, branch jd/queueboosts

Use calloc(3) and recallocarray(3) instead of alloc + memset(0).

2017-04-12T18:24:37Z

ok deraadt

Improve modularization at the chared/read boundary, no functional change.

2016-05-22T23:09:56Z

Stop the read.c module from poking the el_chared.c_macro data structure that used to belong to the chared.c module. Given that no other module, not even chared itself, is using that data, move it into the read modules's own opaque data structure, struct el_read_t. That gets rid of one struct, one #define, one struct member, and one function argument in the chared.h interface. OK czarkoff@

Replace the generated file "fcns.c" by a simpler header "func.h"

2016-05-06T13:12:52Z

included only in the one file needing it, "map.c". That allows to define el_action_t directly in "map.h", which in turn allows to stop including "fcns.h" from "el.h" and include it only in the modules needing it. Now we no longer autogenerate any C files. Feedback and OK martijn@. First version also proofread by Christian Heckendorf .

delete the "private" and "public" preprocessor macros, just use standard C;

2016-04-11T21:17:29Z

OK martijn@

get rid of the non-standard data type "Char" in almost all files;

2016-04-11T20:43:33Z

ok martijn@

Move wrapper macros to the two files actually needing them:

2016-04-11T19:54:53Z

FUNW, Strlen, Strdup, Strcmp, Strncmp, Strncpy, Strncat -> history.c Strchr, tok_strdup -> tokenizer.c FUN, TYPE, STR -> both of these files OK martijn@ Also proofread by Christian Heckendorf who reported some whitespace issues in parse.c.

Delete 26 wrapper macros and two wrapper functions that are no

2016-04-09T20:15:26Z

longer needed now that we always compile with wide character support, reducing code obfuscation. OK czarkoff@ martijn@. Diff also proofread by Christian Heckendorf .

Reduce the FUN() macro madness by no longer applying it to el_[w]getc(3).

2016-03-21T15:25:39Z

Always use el_wgetc(3) internally. In the !WIDECHAR case, casting the result to (Char) is safe because the function returns a byte rather than a character in that case. No functional change except for fixing a printf(3) format string issue when compiled with DEBUG_READ and WIDECHAR. OK czarkoff@

Cleanup of standard header inclusion:

2016-03-20T23:48:27Z

1. Add the missing to sig.c. 2. Do not include standard headers from private headers "chared.h" and "el.h", include them directly where needed. 3. Delete a few needless inclusions of . 4. Sort the standard headers. 5. Delete _GNU_SOURCE weirdness from histedit.h, that file doesn't even need the access to wcsdup(3) mentioned in the comment. 6. Delete some trailing blanks and blanks before tabs. OK czarkoff@

Cleanup of private header inclusion:

2016-03-20T22:57:59Z

1. Do not include private headers from "chared.h", "hist.h", "prompt.h", "refresh.h", "search.h", "sig.h", "terminal.h", "tty.h". The only private header having to include other private headers is "el.h". 2. Do not include "common.h", "parse.h", "help.h" from "el.h", and do not include "emacs.h" and "vi.h" from "chared.h", include them directly where needed. 3. Do include "fcns.h" from "el.h" because el_func_t is needed for "map.h". 4. Do not include private headers again that are already included by "el.h". 5. Include private headers after standard headers. OK czarkoff@