wireguard-openbsd/lib/libedit/read.c, branch jd/queueboosts

el_map.alt can never be NULL, delete dead code

2016-05-25T09:36:21Z

OK czarkoff@

Saving errno in el_errno is only needed for one purpose:

2016-05-25T09:23:49Z

Restoring the original errno found in el_wgetc() after el_wgets() did some cleanup that may have changed errno. Improve clarity and robustness of the code by not setting and inspecting el_errno where it isn't needed; in particular, let keymacro_get() properly report read failure to read_getcmd(). Move el_errno to el_read_t because it's only used in read.c. Never set errno back to zero. Checked with a test program installing a USR1 signal handler without SA_RESTART, for the cases read_getcmd(), ed_quoted_insert(), keymacro_get(), ed_command(), and EL_EDITMODE=0. OK czarkoff@

Remove debugging ifdefs.

2016-05-24T18:06:30Z

I'm debugging the read module for weeks now, but these ifdefs aren't helpful. OK cpp(1).

Improve modularization at the chared/read boundary, no functional change.

2016-05-22T23:09:56Z

Stop the read.c module from poking the el_chared.c_macro data structure that used to belong to the chared.c module. Given that no other module, not even chared itself, is using that data, move it into the read modules's own opaque data structure, struct el_read_t. That gets rid of one struct, one #define, one struct member, and one function argument in the chared.h interface. OK czarkoff@

Move the declaration of the function pointer type el_rfunc_t

2016-05-20T15:30:17Z

from the private header "read.h" to the public header . That's not an interface change, it was already used and documented publicly, merely not properly declared. Improve encapsulation: Make el_read a pointer to an opaque struct in struct editline, such that "read.h" no longer needs to be included from "el.h" but only from the two files using it, read.c and el.c. Only pass the required el_read_t to el_read_{s,g}etfn(), do not pass the full struct editline. OK czarkoff@, also proofread by Christian Heckendorf .

Replace the generated file "fcns.c" by a simpler header "func.h"

2016-05-06T13:12:52Z

included only in the one file needing it, "map.c". That allows to define el_action_t directly in "map.h", which in turn allows to stop including "fcns.h" from "el.h" and include it only in the modules needing it. Now we no longer autogenerate any C files. Feedback and OK martijn@. First version also proofread by Christian Heckendorf .

Re-introduce the following commit:

2016-04-13T09:42:41Z

OpenBSD read.c rev. 1.4 1997/06/10 20:10:13 millert FIONREAD takes int *, not long * It got lost in the following merge from NetBSD: OpenBSD read.c rev. 1.10 2003/10/31 08:42:24 otto OK millert@ martijn@

Cleanup, no functional change:

2016-04-12T09:07:21Z

* Make the return value from read_getcmd() less confusing. * No need to store that return value; testing it once is enough. * Get rid of one #ifdef section in el_wgets(). OK czarkoff@ martijn@

* Delete the unimplemented feature XK_EXE.

2016-04-12T09:04:02Z

* Delete the unused macro MIN(). No functional change. OK czarkoff@ martijn@

delete the "private" and "public" preprocessor macros, just use standard C;

2016-04-11T21:17:29Z

OK martijn@