wireguard-openbsd/lib/libedit/readline.c, branch jd/queueboosts

read() returns -1 on failure

2019-08-14T08:31:00Z

ok yasuoka@

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

Fix a crash in stifle_history() that occurred when the history

2016-05-31T16:12:00Z

contained more than twice as many entries as the new limit: The argument of remove_history() only counts existing elements, not those previously deleted. Crash found by bentley@ when exiting sqlite3(1).

Fix next_history() and previous_history():

2016-05-10T11:07:53Z

* The meaning of "next" and "previous" is exchanged in readline(3) with respect to editline(3); this part of the patch from Bastian Maerkisch. * next_history() can move beyond the newest entry; issue pointed out by Bastian Maerkisch, fix by me. While here, make the documentation of ed-next-history, ed-prev-history, H_NEXT, and H_PREV more precise. OK czarkoff@.

Fix history_get():

2016-05-10T10:49:37Z

* Respect history_base. * Bail out early for arguments that are too small. * Select entry by readline offset, not by editline event number. * Restore history cursor in case of failure. This fixes the test_remove() regression test. Based on a patch from Bastian Maerkisch . Dmitrij Czarkoff pointed out a flaw in it that i fixed. OK czarkoff@.

Fix stifle_history(): Remove excessive entries, if any.

2016-05-09T12:31:55Z

Based on a patch from Bastian Maerkisch , with an additional fix for a memory leak by me. OK czarkoff@

Change where_history() to agree with the GNU implementation:

2016-05-08T13:52:33Z

Return 0 for the oldest entry and increment by 1 for each newer, non-deleted entry. This fixes the test_where() regression test. Patch from Bastian Maerkisch . OK czarkoff@.

Make the history_set_pos() return values agree with the GNU implementation.

2016-05-08T13:34:35Z

Patch from Bastian Maerkisch with a minor tweak from Christos Zoulas. Fixes the test_set_pos_return_values() regression test. OK czarkoff@, also proofread by zhuk@ and by Christian Heckendorf .

Replace the generated file "fcns.c" by a simpler header "func.h"

2016-05-06T13:12:52Z

included only in the one file needing it, "map.c". That allows to define el_action_t directly in "map.h", which in turn allows to stop including "fcns.h" from "el.h" and include it only in the modules needing it. Now we no longer autogenerate any C files. Feedback and OK martijn@. First version also proofread by Christian Heckendorf .

Always compile with WIDECHAR on and delete that preprocessor switch.

2016-04-09T19:31:55Z

OK martijn@. Diff also proofread by Christian Heckendorf .