wireguard-openbsd/lib/libevent, branch jd/queueboosts

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

Fixed integer overflow with an excessively large amount of events.

2019-05-08T17:33:22Z

While at it: KNF and switch from reallocarray to recallocarray. ok tedu

Fixed endless loop/ OOB write on 64 bit systems with large buffers.

2019-05-03T16:31:34Z

If a buffer exceeds UINT_MAX (which is only possible on 64 bit systems) an endless loop or OOB write can occur in buffer-specific readline functions. Switching variables in function scope to size_t solves these issue because relevant fields in struct buffer are already size_t. ok cheloha, deraadt, nicm, tedu

Tweaks previous: gettime() can be void, use TIMESPEC_TO_TIMEVAL

2019-05-01T19:14:25Z

ok nicm@ tobias@ cheloha@

Require clock_gettime(CLOCK_MONOTONIC) and remove fallback code

2019-05-01T19:12:47Z

If clock_gettime(CLOCK_MONOTONIC) fails here, something is really wrong. Lots of userland already require it anyway. Removing the fallback code means less code, less global state and less fiddling with the timeheap internals. ok nicm@ tedu@ tobias@ cheloha@

Switched min_heap to size_t to prevent integer overflows.

2019-04-29T17:11:51Z

Also, as deraadt suggested, switched realloc to recallocarray to at least prevent uninitialized memory to be used as pointers in case of other programming errors. A proper solution (not using an array) needs more work. This change occured in sync with upstream libevent 2.2. with input by and ok bluhm, jca, tedu

knf, ok bluhm

2019-04-20T23:22:28Z

unfold some compound operations to make this easier to follow

2019-04-18T23:44:21Z

Document bufferevent_setwatermark(). Initial diff from Geoff Hill on tech@ with

2018-09-23T08:56:19Z

some tweaks. With feedback and ok jmc@

Mention some missing libevent macros.

2018-07-26T12:50:04Z

ok jmc@, benno@, "yes" deraadt@