wireguard-openbsd/lib/libssl/tls13_record_layer.c, branch jd/queueboosts WireGuard implementation for the OpenBSD kernel https://git.zx2c4.com/wireguard-openbsd/atom/lib/libssl/tls13_record_layer.c?h=jd%2Fqueueboosts 2020-06-01T19:51:31Z Split the handling of post handshake handshake messages into its 2020-06-01T19:51:31Z tb tb@openbsd.org 2020-06-01T19:51:31Z urn:sha1:0cd4ba86ab5d745b33a197e3095e6b002b211606 own recv function. This simplifies tls13_recod_layer_read_internal() greatly and makes the phh handling easier to reason about since the code is no longer glued to the right hand edge of the terminal. ok jsing Add a mechanism to set an alert in those parts of the read half of 2020-06-01T07:59:49Z tb tb@openbsd.org 2020-06-01T07:59:49Z urn:sha1:4c4033b4c5ffdc65b411c3e48abfe7488dec53c9 the record layer that don't do I/O themselves. Use this mechanism to send a record overflow alert for messages that have overlong plaintext or inner plaintext. Fixes most of the remaining record-layer-limits failures of tlsfuzzer. ok jsing Handle the case where we receive a valid 0 byte application data record. 2020-05-29T17:54:58Z jsing jsing@openbsd.org 2020-05-29T17:54:58Z urn:sha1:d69bc5b96c0ed03c35613c574f6f043725708ed7 In this situation we cannot return zero bytes, as that signals EOF. Rather we need to return TLS13_IO_WANT_POLLIN so tell the caller to call us again, at which point we'll pull up the next record. ok tb@ Add additional length checks for TLSv1.3 plaintext and inner plaintext. 2020-05-26T16:54:50Z jsing jsing@openbsd.org 2020-05-26T16:54:50Z urn:sha1:8d0f08c23e55ba46334df26224d928ad096671e2 Reminded by and ok beck@ Provide the option to retry or return after post-handshake messages. 2020-05-23T11:57:41Z jsing jsing@openbsd.org 2020-05-23T11:57:41Z urn:sha1:3aebe4407e38a64005589dab70bb15ce7f7f5243 In TLSv1.3 post-handshake handshake messages are used for key updates and session tickets. These are in-band and mean that when the upper layer goes to read application data, we can end up reading and having to process handshake messages - this option changes whether we retry and read the next TLS record, or if we return, signalling that we want more data to be available. ok beck@ inoguchi@ tb@ Revert 1.43 - this fix for PHH in blocking mode breaks SSL_accept and 2020-05-20T14:58:33Z beck beck@openbsd.org 2020-05-20T14:58:33Z urn:sha1:3a2e4416b54dfa6e39eb82ed91a930265a05305f SSL_connect in blocking mode. While this will probably need a rethink, until we land on a solution for PHH in blocking mode, the breakage this causes is visible in real things, and we've only managed to hit the PHH breakage in a test case. ok tb@ Return TLS13_IO_WANT_POLLIN after processing post-handshake messages. 2020-05-16T18:00:29Z jsing jsing@openbsd.org 2020-05-16T18:00:29Z urn:sha1:acf76599022d9cc260c6327bc31fd213ff8d5b58 After post-handshake handshake messages have been processed, we need to return TLS13_IO_WANT_POLLIN rather than TLS13_IO_WANT_RETRY. The latter will cause us to try to read another TLS record, when there may not be any data available - this will then block in the case of a blocking read. This reverts part of r1.25. Issue noticed by inoguchi@ ok beck@ tb@ Remove a no longer relevant XXX comment. 2020-05-13T17:54:26Z jsing jsing@openbsd.org 2020-05-13T17:54:26Z urn:sha1:de3b0c62e8ee2769d7c826e00c63bec870d1cf45 Propagate record overflows to the record layer and alert. 2020-05-11T18:08:11Z jsing jsing@openbsd.org 2020-05-11T18:08:11Z urn:sha1:6423e56fc083c24af016f600b9cd71874970c5a3 ok beck@ tb@ Add record version checks. 2020-05-11T18:03:51Z jsing jsing@openbsd.org 2020-05-11T18:03:51Z urn:sha1:204f36c2801813e90c79fe8b14e633e73b4bb770 When legacy version is below TLSv1.2 ensure that the record version is SSL3/TLS, however when the legacy version is set to TLSv1.2 require this specifically. ok beck@ tb@