wireguard-openbsd/lib/libtls/tls_util.c, branch jd/queueboosts WireGuard implementation for the OpenBSD kernel https://git.zx2c4.com/wireguard-openbsd/atom/lib/libtls/tls_util.c?h=jd%2Fqueueboosts 2019-04-13T18:47:58Z Null out pointers on asprintf() failure. 2019-04-13T18:47:58Z tb tb@openbsd.org 2019-04-13T18:47:58Z urn:sha1:0f235647877a526523961ad0c5962410ae3a942b These pointers will be passed to free. According to asprintf(3), "on OpenBSD, ret will be set to the null pointer, but this behavior should not be relied upon." ok jsing Only assign destlen when src is non-NULL. 2019-04-04T15:10:10Z jsing jsing@openbsd.org 2019-04-04T15:10:10Z urn:sha1:a2b2c5372fe238427b48cf679d060e81e6eaa40d This avoids ever having a non-zero len with a NULL pointer. Assert tedu's copyright since some of the code moved here is his. 2018-02-08T07:55:29Z jsing jsing@openbsd.org 2018-02-08T07:55:29Z urn:sha1:15ba8e50b96ecc48a19bca342e70997c029121ee Split keypair handling out into its own file - it had already appeared 2018-02-08T05:56:49Z jsing jsing@openbsd.org 2018-02-08T05:56:49Z urn:sha1:bb4cb1b0441fa059bcc631311ed93636eefbc1b2 in multiple locations. ok beck@ Be consistent with the goto label names used in libtls code. 2018-02-05T00:52:24Z jsing jsing@openbsd.org 2018-02-05T00:52:24Z urn:sha1:7add217b8eb9ea81a3752d76fa1861ba7106469a No change to generated assembly. Use the tls_password_cb() callback with all PEM_read_bio_*() calls, so that 2017-06-22T18:03:57Z jsing jsing@openbsd.org 2017-06-22T18:03:57Z urn:sha1:a192468a6a296bf47a6f2939ab2280c765a76555 we can prevent libcrypto from going behind our back and trying to read passwords from standard input (which we may not be permitted to do). Found by jsg@ with httpd and password protected keys. Use freezero() for the tls_load_file() failure case, since we're 2017-05-06T21:34:13Z jsing jsing@openbsd.org 2017-05-06T21:34:13Z urn:sha1:54356a5d711c8d80e4edec59da532ab29b95e04d potentially dealing with key material. Also switch a calloc to malloc, since we immediately copy the same amount of data to the newly allocated buffer. BIO_free_all() and EVP_PKEY_free() can be called with NULL. 2017-05-06T21:25:15Z jsing jsing@openbsd.org 2017-05-06T21:25:15Z urn:sha1:55177a383a974273e6d8cd8f2e29101bc2313c87 Provide a tls_unload_file() function, that frees the memory returned from 2017-05-06T20:57:45Z jsing jsing@openbsd.org 2017-05-06T20:57:45Z urn:sha1:028ca023e5ccdd92807421708f890771df281e1c a tls_load_file() call, ensuring that it the contents become inaccessible. This is specifically needed on platforms where the library allocators may be different from the application allocator. ok beck@ Address some signed vs unsigned warnings and check that an integer value 2016-11-04T15:59:16Z jsing jsing@openbsd.org 2016-11-04T15:59:16Z urn:sha1:dad7bfe2e40ae1373c03c57f426ec8b035bd33df is positive before passing it to several functions as a size_t. Additionally, in tls_load_file() there is not much point using calloc(), when we're immediately reading into the buffer (having an extra byte for NUL termination seems pointless given the API). ok beck@ miod@