wireguard-openbsd/libexec/fingerd/fingerd.c, branch jd/histogram

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

Move pledge to after getopt, when the finger program becomes known

2018-08-03T15:14:18Z

(defaults to /usr/bin/finger, but can be redefined with -P option). Then unveil that program for "x" (execution), and pledge as before. No other filesystem accesses occur after that point.

4-step pledge in a program noone really uses anymore.

2015-11-13T01:26:33Z

pledge "stdio inet dns proc exec" at startup. In the logging codepath, "stdio dns proc exec" after getpeername() drop to stdio proc exec(), before fork / execve Parent moving data out of the pipe only needs "stdio"

_exit() in the child; as a result, must use syslog() directly.

2015-11-13T01:23:59Z

Replace with and other less dirty headers where

2015-01-16T06:39:28Z

possible. Annotate lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)

remove some unnecessary sys/param.h inclusions

2012-12-04T02:24:45Z

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and

2009-10-27T23:59:19Z

unmaintainable). these days, people use source. these id's do not provide any benefit, and do hurt the small install media (the 33,000 line diff is essentially mechanical) ok with the idea millert, ok dms

Prevent a buffer underrun if a line is received which only contains

2008-08-11T17:17:53Z

(multiple) @. ok millert, otto

Don't shadow err(3).

2006-08-19T06:01:00Z

Store strlen() results in a size_t. Add __dead to both usage() and logerr(). Get rid of /* NOTREACHED */. Get rid of extraneous _exit(). Calls err(3) on getpeername failure. ``reads well to me!'' avsm@

Incllude to get MAXHOSTNAMELEN

2006-01-17T17:51:21Z