wireguard-openbsd/libexec/ftpd/ftpd.c, branch jd/simplify-queueing

Simplify globbing of ftpd(8)s list and nlst commands.

2020-01-15T22:06:59Z

Also avoid command option injection for ls(1). OK martijn@

snprintf/vsnprintf return < 0 on error, rather than -1.

2019-07-03T03:24:01Z

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

rm dead code and simplify ftpd_popen. this code has only called

2019-05-08T23:56:48Z

its statically linked ls_main for some time now. from Jan Klemkow ok deraadt

Flip snprintf(3) error check to align it with the man page example.

2018-12-11T18:19:55Z

No functional change. suggested by tb@; from Jan Klemkow

Convert some variables with non-negative values to unsigned type

2018-12-11T18:03:11Z

to avoid comparison of integers of different signs. from Jan Klemkow; OK tb@

Use a single "opt" variable for all setsockopt calls in getdatasock().

2016-09-03T15:00:48Z

on = 65536; if (setsockopt(... &on ...) is slightly misleading.

Set "lowdelay" and "throughput" Traffic Class on command & data IPv6 sockets.

2016-09-03T14:53:20Z

Don't attempt to support IPv4-mapped IPv6 addresses.

2016-08-31T13:43:36Z

We don't consider support for those addreses as desirable, so let's not give a bad example by keeping application code to handle them. This is dead code on OpenBSD anyway since we do not support IPv4-mapped stuff. But let's keep the check to log and warn the admin if the code gets ported elsewhere. Porters of this code should ensure that IPv6 sockets can't see IPv4-mapped addresses by using the IPV6_V6ONLY sockopt. Discussed with & ok tedu@ For a rationale, see https://tools.ietf.org/html/draft-itojun-v6ops-v4mapped-harmful-02

remove ifdef for all the features we have.

2016-08-30T14:56:39Z

retain disabled ip4in6 code until its future is decided. ok deraadt jca