wireguard-openbsd/libexec/ftpd, branch master

We know about optreset from unistd.h.

2020-12-27T15:11:04Z

From Jan Stary, thanks. OK martijn

Avoid passing a NULL name to retrieve(), use "." instead.

2020-03-04T20:17:48Z

Fixes a "vfprintf %s NULL" warning in ftpd. OK deraadt@ tb@

Simplify globbing of ftpd(8)s list and nlst commands.

2020-01-15T22:06:59Z

Also avoid command option injection for ls(1). OK martijn@

snprintf/vsnprintf return < 0 on error, rather than -1.

2019-07-03T03:24:01Z

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

rm dead code and simplify ftpd_popen. this code has only called

2019-05-08T23:56:48Z

its statically linked ls_main for some time now. from Jan Klemkow ok deraadt

Flip snprintf(3) error check to align it with the man page example.

2018-12-11T18:19:55Z

No functional change. suggested by tb@; from Jan Klemkow

Convert some variables with non-negative values to unsigned type

2018-12-11T18:03:11Z

to avoid comparison of integers of different signs. from Jan Klemkow; OK tb@

Don't send multiple error messages in response to a single command

2017-04-27T13:30:54Z

While a few commands (such as HELP and NOOP) are allowed in between USER and PASS, most of the others are not. However if such command is issued, ftpd should abort the command evaluation early and reply with "530 Please login with USER and PASS." From form@, with input from deraadt@ and OK millert@

memset() of password field should be explicit_bzero().

2017-04-17T21:49:01Z

[Not using freezero() in yacc files yet]