wireguard-openbsd/libexec/spamd/sync.c, branch jd/simplify-queueing

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

- Remove useless var assignment

2016-10-20T21:09:46Z

- Use memset(*b, 0, len) instead of bzero(*b, len) - Use memcpy(*dst, *src, len) instead of bcopy(*src, *dst, len) - Use explicit_bzero(3) instead of bzero(3) to clean temporary HMAC Remarks from deraadt@ (duly noted!!), reviewed and OK by henning@ and tb@

Delete a bunch of unnecessary #includes

2014-11-23T21:19:47Z

Use instead of ok krw@

the time being handled here is strictly unsigned 32 bit

2013-11-19T18:33:07Z

ok beck phessler

rather than a mishmash of headers, this only needs

2012-12-04T02:36:38Z

with guenther

PR 6090 - from Olli Hauer

2009-04-20T17:42:21Z

A number of small improvements: - patch for empty lines and comments in alloweddomains_file - remove some whitespaces at end of line. - document comment and empty line handling - Remove unused parameter 'r' from getopt in spamd.c, it is removed in the 'switch statement' but not in getopt. http://www.openbsd.org/cgi-bin/cvsweb/src/libexec/spamd/spamd.c.diff?r1=1.94;r2=1.95;f=h - replace atoi with strtonum - make debug output more usefull, display only what will be synced and not a second message which prints always "sync trapped %s" - some cosemtic and whitespace fixes.

version 2 of spamd sync protocol for two reasons:

2008-05-22T19:54:11Z

1) ip addresses were accidentally being sent in host-byte order, which caused compatibility problems (spotted by jbg) 2) the sub-headers in the frame were not natively aligned, thus timeout values were incorrectly sent by 64-bit machines ok beck

As was done in dhcpd, insert pad blocks after sub-messages to keep the

2008-05-09T07:09:17Z

structures aligned to 16 byte boundaries for maximum portability (somewhat similar to CMSG's). Old spamd's and new spamd's can still communicate with this change. It would be nice if someone tested spamd on 64-bit unaligned architectures (with and without this change) ok beck

check if the received buffer of a sync element is even big enough to

2008-05-07T08:50:15Z

hold the header with length field. ok deraadt@ beck@

Add a missing length check of received spamd sync packet headers.

2007-12-27T10:50:06Z

From Diego Giagio (dgiagio at gmail) with input from tedu@