wireguard-openbsd/libexec/spamd, branch master

By now we are already confident that pledge(2) "just works(tm)" and that it can

2019-08-06T13:34:36Z

be used to effectively remove filesystem access. That being said, in spamd(8) when I pledge(2)d it the main priv process got "stdio inet" which means there's no fs access at all so calling chroot(2)/chdir(2) here doesn't get us any additional protection. Just remove them. OK deraadt@ and no objections from schwarze@

Ever since I introduced pledge(2) on spamd(8) the chroot'ed process, if running

2019-07-24T18:41:05Z

in default, cannot get anywhere near the filesystem since its only promises are "stdio inet". Furthermore, in blacklist mode this same codepath is not chroot'ed but once again it gets the same pledge(2). Therefore we can remove the BUGS section from spamd(8)'s manpage. OK millert@ deraadt@

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

I am retiring my old email address; replace it with my OpenBSD one.

2019-01-25T00:19:25Z

When spamd(8) runs in greylist mode in the parent process (which runs

2018-10-25T06:42:35Z

greywatcher()) we know that the only files that it will ever access are PATH_SPAMD_DB in rw mode, alloweddomains_file in r and that it will need to execute PATH_PFCTL so we can unveil(2) them with those permissions. OK deraadt@ millert@ beck@

More "explicitely" -> "explicitly" in various comments.

2018-10-22T17:31:24Z

ok guenther@ tb@ deraadt@

nuke trailing whitespace

2018-04-26T08:57:07Z

Make blacklist entries override the whitelist. When running spamd

2017-10-18T17:31:01Z

in greylisting mode, it is not uncommon for an IP to get whitelisted before it shows up on a spam blacklist. With this change, spamd will check its blacklists before adding a WHITE entry to the pf table. If the IP matches a blacklist, the WHITE entry will be removed. OK phessler@

Use a binary search to speed up blacklist lookups. OK phessler@

2017-10-17T13:52:10Z

Check for asprintf() returning -1 instead of assuming that the

2017-10-12T16:22:33Z

pointer will remain unchanged when fails. OK deraadt@