wireguard-openbsd/sbin/dhclient/parse.c, branch jd/queueboosts

Cleanup/simplify parse_number():

2019-07-22T17:20:06Z

1) Restructure to explicitly set a long long result and take the desired low/high constraints for strtonum(). 2) No need to use a temporary variable when setting long long (a.k.a. time_t) fields. 3) Fewer magic numbers when processing integer valued option data. Less memcpy()'ing where a cast or two is sufficient to make integer assignment work. No intentional functional change.

Restructure parse_semi() so it resembles the other parse_*

2019-07-21T15:59:51Z

functions.

Replace malloc()/memcpy() with strdup() in parse_string(). Nuke 'len' parameter

2019-07-21T15:47:02Z

to parse_string() in favour of taking strlen() of resulting string in the few cases that it is of interest.

Parsing error messages display only the first 80 characters of the

2019-03-19T23:57:30Z

offending line. It is fruitless to try to position the "^" at a character more than 80 characters from the start of the line.

parse_lease_time() is an unnecessary abstraction. Just use

2018-01-04T03:02:05Z

parse_number('L') since it is parsing unsigned 32bit integers.

We only parse decimal numbers, so parse_decimal() -> parse_number() to

2018-01-04T02:27:55Z

match grammar comments and improve euphony.

Use lease 'epoch' (time lease was acquired) to calculate timers for

2017-11-09T12:34:25Z

renew/rebind/expiry. Treat renew/rebind/expiry statements in leases as comments for human consumption.

Add format 't' to parse_decimal() for signed 64-bit

2017-11-06T12:51:53Z

integers.

Use same parse_warn() verbiage in parse_lease_time() as that

2017-10-23T13:15:57Z

emitted when other unsigned 32-bit values are parsed. i.e. "expecting integer between 0 and 4294967295". No need to make people google what "unsigned 32-bit decimal value" means.

Nuke special case for '\n' in skip_to_semi() and

2017-10-19T13:44:31Z

associated weird comment about parsing resolv.conf. dhclient.conf and dhclient.leases. are semi-colon oriented and not line oriented. '\n' is never returned by get_token().