wireguard-openbsd/sbin/disklabel/disklabel.c, branch jd/queueboosts

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

Use consistant idiom for checking return value of

2019-04-02T01:47:49Z

ioctl() (i.e. == -1). Don't prepend 'ioctl ' to ioctl name in error or warning messages. Always put the ioctl name in emitted messages. No intentional functional change.

No need for RESTORE (-R) to call DIOCGINFO and mpsave() twice in

2019-04-02T01:10:29Z

normal mode. And not overwriting any -F/-f file when in -n (donothing) mode is likely less surprising.

Remove l_perror() and rely on warn() for failure

2019-04-02T00:58:00Z

messages in writelabel(). Consolidate two consecutive 'if (!donothing) ...' blocks into one.

No need to save/restore fields across the invocation of

2019-04-01T00:12:02Z

getasciilabel() when getasciilabel() explicitly avoids changing those fields. ok otto@

Nuke stray/pointless 'volatile' for local var.

2018-08-11T18:37:21Z

Nuke some leading spaces and mis-indentations that crept in over the

2018-07-03T06:42:13Z

years. ok otto@

No need for print_unit to be a global.

2018-07-03T06:37:45Z

ok otto@

Bunch of whitespace fixes.

2018-02-25T17:24:44Z

ok otto@

don't be silent on auto-allocation failure in write mode. ok millert@ krw@

2017-09-29T18:32:09Z