wireguard-openbsd/sbin/pfctl/pfctl_optimize.c, branch jd/queueboosts

sbin/pfctl: replace TAILQ concatenation loop with TAILQ_CONCAT

2020-01-28T15:40:35Z

OK kn@, sashan@, florian@

Do the actual pfr_strerror() to pf_strerror() rename

2020-01-15T22:38:30Z

Missed in previous

Unify error message for nonexisting anchors

2020-01-15T22:31:51Z

pf(4) returns EINVAL for DIOCGETRULE, DIOCGETRULES and DIOCGETRULESET if the specified anchor does not exist. Extend and rename {pfr -> pf}_strerror() to make error message more consistent. There are other occasions as well but those need additional tweaks; that's stuff for another diff. OK and rename from sashan

Avoid optimizing empty rulesets

2019-12-12T21:00:51Z

All optimizations work on actual rules; if there are none, return early. While here, tell which ruleset/anchor is being optimized to make the debug message actually useful. OK mikeb

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

Remove pfctl_*_pool() remnants

2019-03-07T08:01:52Z

Left behind in pfctl_parser.h revision 1.91 "First pass at removing the 'pf_pool' mechanism [...]" These functions don't exist anymore, no object change. OK procter

Unbreak build under OPT_DEBUG

2019-01-03T22:49:00Z

In r1.39 I removed the `af' parameter from `unmask()' but accidently zapped the macro's closing paranthese. Since DEBUG() is needlessly under an OPT_DEBUG guard, this was not effecting normal builds. Add the missing ')' and remove the ifdef. OK sashan

Remove unused af argument from unmask()

2018-09-06T15:07:33Z

This has been unused for years. While here, zap the duplicate function signature from pfctl.h (already present in pfctl_parser.h); spotted by sashan, thanks. OK sashan

- patching use-after-free and innocent memory leak in pfctl_optimzie.c

2017-11-25T22:20:06Z

OK bluhm@

- pfctl rule optimizer: anchor name vs. anchor path mix up

2017-11-25T22:16:47Z

OK bluhm@