wireguard-openbsd/sbin/pflogd, branch jd/queueboosts

use _PATH_ names for unveil if possible

2019-11-27T17:49:09Z

mop up for the pcap.3 rename;

2019-08-30T17:51:47Z

help/ok deraadt

Fix copy pasto, re-add missing goto in error path.

2019-07-25T17:32:33Z

Yet another workaround for crappy libpcap API design

2019-07-25T14:53:21Z

Add an internal version of pcap_open_live that ensures bpf(4) devices are opened read-only before locking. Neither pflogd(8) or spamlogd(8) require write access to bpf(4). Inspired by similar solution in OpenBSD tcpdump(8). pflogd(8) was safe since being unveiled last year, but spamlogd(8) was having /dev/bpf opened O_RDWR. Issue discovered by bluhm@'s unveil(2) accounting commit. ok deraadt@, mestre@ (thanks for testing spamlogd!)

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.

Unveil pflogd(8). Similiar to florian@'s recent changes to ifconfig(8),

2018-08-26T18:26:51Z

the priviledged parent cannot be pledged due to certain ioctls, but we can use unveil(2) to lock down its access to the filesystem. To be able to use hostnames/dns in tcpdump-like filter expressions, we unveil /etc/{resolv.conf,hosts,services} "r", kept in sync with the kernel bypass for pledge("dns") Additionally, we need to unveil /dev/bpf "r" and the output log file "rwc". The unpriviledged child is pledged "stdio recvfd" and thus does not need any unveils. With feedback/testing from florian@, deraadt@ ok florian@ deraadt@

pflogd(8): don't try to rename(2) broken/invalid pflog files, instead,

2018-08-26T18:24:46Z

suspend logging until the log file has been moved out of the way, and we have received either SIGHUP or SIGALRM. ok florian@ deraadt@

Rework pflogd(8)'s fork+exec model; re-exec the unpriv child, not the

2017-09-09T13:02:52Z

privileged parent. Based on feedback from deraadt@ and bluhm@ (worked on syslogd). ok deraadt@

Bring back the "Exiting" log message in pflogd(8), but do not set

2017-09-08T13:34:29Z

the LOG_CONS flag in openlog(3). This avoids output to the console on shutdown. Discussed with benno@ who wants to see when a deamon stops during normal system operation. OK brynet@

pflogd(8) currently spams the console on shutdown if syslogd(8) wins the

2017-09-06T12:43:16Z

race to die, so just stop logging pflogd exits. This logging probably comes from the fact that pflogd was largely based on syslogd. Removes the annoying "pflogd[23954]: Exiting" messages pointed out by deraadt@ Also cleanup some missed SIGCHLD handling code that is no longer needed. "LGTM" mikeb@