wireguard-openbsd/sbin/ping, branch master

exclamation mark needs escaped too;

2021-02-21T17:18:01Z

Add ping -g, a concise display format similar to that used by other

2021-02-21T10:38:42Z

network devices that shows one character per echo request (! for normal response, . for timed out, D for duplicate, T for truncated) making it easier to identify patterns of loss over periods of time. ok remi@ kn@, feedback from deraadt@ chris@ !!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!.........!!!!!!!!!!!!!!!!!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!.........!!!!!!!!!!!!!!!!!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!.........!!!!!!!!!!!!!!!!!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!..........!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!..........!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!..........!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!.....!!!!!!!!!!!!!!

If we manage to send all "count" flood pings before receiving all

2020-12-29T16:40:47Z

answers we would exit after receiving the first answer and claiming a (huge) packet loss. OK benno

ICMP raw sockets start to receive packets as soon as they are created

2020-10-21T11:11:58Z

by socket(2). They also receive all ICMP packets on the system, for example from parallel running ping(8)s. After creating the raw socket ping(8) sets various socket options with setsockopt(2) and assumes that they apply to all packets it later processes. For example ping6(8) uses setsockopt(IPV6_RECVHOPLIMIT) to print the IPv6 hop count. Packets received between the socket(2) and setsockopt(2) call however do not have the hoplimit information and ping6(8) prints a wrong and missleading warning. To avoid this we have to drain our socket of packets we received before we were fully setup. Problem reported and testing by martijn Input deraadt OK benno

Missing space for '-i interval' option error message.

2020-09-21T12:19:08Z

From . Thanks!

Simplify and unify wording for the -I sourceaddr option in various places.

2020-02-11T18:41:39Z

This is somewhat related to the "-b bind_addr" option some programs have, which should get some cleanup also... input florian claudio jmc

ping(8): improve "-i wait" parsing and error-checking code

2020-01-04T01:00:18Z

- Never accept negative values. - Cap the interval at UINT_MAX seconds to avoid strange rounding behavior at the end of the input range. - Use error messages that resemble other parts of the tree where we are able to use strtonum(3). - Leverage modf(3) for cleaner code. - Call it "-i interval" to avoid accidental visual similarity to "-w maxwait". With input from cjeker@, kettenis@, kn@. ok kn@

At startup, unveil entire filesystem to read-only. If after privdrop, some

2019-08-28T20:03:51Z

implausible bug existed in the socket setup (mostly dns-related and setsockopt) it would be largely neutered. of course, a very restrictive pledge is installed soon after that... ok mestre brynet florian

ping(8): don't round inter-packet delay up to HZ

2019-07-20T00:49:54Z

ping(8) doesn't know the value of HZ and shouldn't round the user's packet wait up to whatever it thinks HZ is. If the period is too small the interrupt will simply fire less often than instructed. The kernel will do the right thing regardless. Given the rarity of this usage we don't really need to print a warning, either. ok millert@

When system calls indicate an error they return -1, not some arbitrary

2019-06-28T13:32:41Z

value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.